Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File download feature #190

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

arabakevin
Copy link
Contributor

@arabakevin arabakevin changed the title File sharing feature File download feature Sep 29, 2020
@arabakevin
Copy link
Contributor Author

arabakevin commented Oct 1, 2020

Here we can see the preview of the document now.
Capture d’écran 2020-10-01 à 11 07 21
We use different types of files we add the preview of each one:

  • word file
    Capture d’écran 2020-10-01 à 10 45 22
  • pdf file
    Capture d’écran 2020-10-01 à 10 46 44
  • excel file
    Capture d’écran 2020-10-01 à 10 47 01
  • power point file
    Capture d’écran 2020-10-01 à 10 47 19
  • zip file
    Capture d’écran 2020-10-01 à 10 47 34
  • jpg/jpeg file
    Capture d’écran 2020-10-01 à 10 47 56
  • png file
    Capture d’écran 2020-10-01 à 10 48 12
    -svg file
    Capture d’écran 2020-10-01 à 10 48 29
  • csv file
    Capture d’écran 2020-10-01 à 10 48 42
  • and if we have an other type file we will have this icon
    Capture d’écran 2020-10-01 à 10 49 12

@stale
Copy link

stale bot commented Oct 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 11, 2020
@arabakevin
Copy link
Contributor Author

Hi @mattmezza,
can you process at the code review please ?
If missing something don't hesitate.
Thanks.

@stale stale bot removed the stale label Oct 11, 2020
Copy link
Owner

@mattmezza mattmezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a great addition @arabakevin ! You are the best!
There are some things that we could fix before merging :)
Please rebase on current master before starting to tackle this.

@a-kriya please feel free to chip in with your review too

demo/src/App.vue Outdated Show resolved Hide resolved
src/Message.vue Outdated Show resolved Hide resolved
src/components/mimes/IconPdfFile.vue Outdated Show resolved Hide resolved
src/messages/FileMessage.vue Outdated Show resolved Hide resolved
src/messages/FileMessage.vue Outdated Show resolved Hide resolved
src/messages/FileMessage.vue Outdated Show resolved Hide resolved
src/Message.vue Outdated Show resolved Hide resolved
src/Message.vue Outdated Show resolved Hide resolved
Copy link
Owner

@mattmezza mattmezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @arabakevin, I could not make it to work as you intended. Could you fix the demo such that it shows the changes you want to the lib to have?

src/messages/FileMessage.vue Outdated Show resolved Hide resolved
src/messages/FileMessage.vue Outdated Show resolved Hide resolved
src/messages/FileMessage.vue Outdated Show resolved Hide resolved
src/assets/download-icon.svg.vue Outdated Show resolved Hide resolved
src/Message.vue Show resolved Hide resolved
src/messages/FileMessage.vue Outdated Show resolved Hide resolved
src/messages/FileMessage.vue Outdated Show resolved Hide resolved
src/messages/ImageMessage.vue Outdated Show resolved Hide resolved
src/messages/FileMessage.vue Outdated Show resolved Hide resolved
refactorisation of method to truncate, calculate size and type of file, fixes syntaxes and download icon has been export as an asset svg
@arabakevin
Copy link
Contributor Author

Hi @arabakevin , @a-kriya ,
i've try to resolve each point.
Can you verify if all it's ok for you ? And if you need something more don't hesitate.
Thanks.

src/messages/FileMessage.vue Outdated Show resolved Hide resolved
src/messages/ImageMessage.vue Outdated Show resolved Hide resolved
src/messages/FileMessage.vue Outdated Show resolved Hide resolved
src/messages/FileMessage.vue Outdated Show resolved Hide resolved
src/messages/FileMessage.vue Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/messages/ImageMessage.vue Outdated Show resolved Hide resolved
src/messages/ImageMessage.vue Outdated Show resolved Hide resolved
@arabakevin
Copy link
Contributor Author

Hi,
Do you need something or more details on README or demo/src/App.vue ?
Thanks

@a-kriya a-kriya linked an issue Dec 9, 2020 that may be closed by this pull request
@@ -67,6 +77,7 @@
<script>
import TextMessage from './messages/TextMessage.vue'
import FileMessage from './messages/FileMessage.vue'
import ImageMessage from './messages/ImageMessage.vue'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was never registered in the components section below on line 87, and thus results in the error:

image

@stale
Copy link

stale bot commented Feb 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 10, 2021
@stale stale bot closed this Feb 17, 2021
@a-kriya a-kriya reopened this Feb 17, 2021
@stale stale bot removed the stale label Feb 17, 2021
@stale stale bot added the stale label Apr 18, 2021
@a-kriya a-kriya removed the stale label Apr 19, 2021
@stale stale bot added the stale label Jun 18, 2021
Repository owner deleted a comment from stale bot Jun 18, 2021
@a-kriya a-kriya removed the stale label Jun 18, 2021
Repository owner deleted a comment from stale bot Jun 18, 2021
@stale
Copy link

stale bot commented Aug 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 17, 2021
@a-kriya a-kriya added pinned and removed stale labels Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File sharing feature
3 participants