fix onStepAwaiting events (#7161)

medusajs · Apr 29, 2024 · edcafa1 · edcafa1
1 parent 11517f0
commit edcafa1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/.changeset/twelve-crabs-clean.md b/.changeset/twelve-crabs-clean.md
@@ -0,0 +1,6 @@
+---
+"@medusajs/workflow-engine-redis": patch
+"@medusajs/orchestration": patch
+---
+
+Fix onStepAwaiting event
diff --git a/packages/orchestration/src/transaction/transaction-orchestrator.ts b/packages/orchestration/src/transaction/transaction-orchestrator.ts
@@ -720,6 +720,9 @@ export class TransactionOrchestrator extends EventEmitter {
                 )
                 .then(async (response: any) => {
                   if (!step.definition.backgroundExecution) {
+                    const eventName = DistributedTransactionEvent.STEP_AWAITING
+                    transaction.emit(eventName, { step, transaction })
+
                     return
                   }
 
@@ -752,9 +755,6 @@ export class TransactionOrchestrator extends EventEmitter {
 
                   await setStepFailure(error)
                 })
-
-              const eventName = DistributedTransactionEvent.STEP_AWAITING
-              transaction.emit(eventName, { step, transaction })
             })
           )
         }

diff --git a/packages/workflow-engine-redis/src/services/workflow-orchestrator.ts b/packages/workflow-engine-redis/src/services/workflow-orchestrator.ts
@@ -573,9 +573,7 @@ export class WorkflowOrchestratorService {
 
         await notify({ eventType: "onStepAwaiting", step })
 
-        if (!step.definition.backgroundExecution) {
-          this.activeStepsCount--
-        }
+        this.activeStepsCount--
       },
 
       onCompensateStepSuccess: async ({ step, transaction }) => {