Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(order): receive return and additional calculations #7314

Merged
merged 6 commits into from
May 14, 2024
Merged

feat(order): receive return and additional calculations #7314

merged 6 commits into from
May 14, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

No description provided.

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner May 13, 2024 17:22
@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 11:09am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 14, 2024 11:09am
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 11:09am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 11:09am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2024 •
edited

⚠️ No Changeset found

Latest commit: bce9cb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

olivermrbl
olivermrbl approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single question, but otherwise LGTM

packages/modules/order/src/services/order-module-service.ts
reference: data.reference,
reference_id: shippingMethodId,
reference: data.reference ?? "fulfillment",
reference_id: data.reference_id ?? shippingMethodId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why do we default toshippingMethodId for the RETURN_ITEM action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference is generic, and could be related to any "reference" and its ID.
We haven't yet created a "return" table. But I believe this will be referenced there.

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit 4ef70d3 into develop May 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carlos-r-l-rodrigues @olivermrbl