Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(modules-sdk): Custom Module definition #7315

Merged
merged 4 commits into from
May 14, 2024
Merged

chore(modules-sdk): Custom Module definition #7315

merged 4 commits into from
May 14, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

No description provided.

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner May 13, 2024 18:05
@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 9:42am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 14, 2024 9:42am
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 9:42am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 9:42am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2024 •
edited

⚠️ No Changeset found

Latest commit: 32ce42e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

olivermrbl
olivermrbl approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup

packages/core/modules-sdk/src/definitions.ts Outdated Show resolved Hide resolved
sradevski
sradevski approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see things getting cleaned up!

packages/medusa/src/loaders/index.ts Outdated Show resolved Hide resolved
@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit e2dfe91 into develop May 14, 2024
17 checks passed
@sradevski sradevski deleted the chore/rm-module-is-legacy branch May 14, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski approved these changes

@adrien2p adrien2p adrien2p approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlos-r-l-rodrigues @sradevski @adrien2p @olivermrbl