-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Just-in-time plugin installation #8482
base: main
Are you sure you want to change the base?
feat: Just-in-time plugin installation #8482
Conversation
👷 Deploy request for meltano pending review.Visit the deploys page to approve it
|
93cc0b1
to
7b9bf26
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8482 +/- ##
==========================================
+ Coverage 91.81% 91.86% +0.05%
==========================================
Files 245 245
Lines 19296 19357 +61
Branches 2152 2156 +4
==========================================
+ Hits 17717 17783 +66
+ Misses 1306 1302 -4
+ Partials 273 272 -1 ☔ View full report in Codecov by Sentry. |
We probably want to suppress install progress to stdout from
|
Yeah, I'd be more than OK with starting to unify our output away from |
601322c
to
44680fa
Compare
Think I have covered all relevant commands here. Wondering if we want a new
I haven't yet addressed install progress/status as logs, but the output is suppressed for |
ad6e137
to
89f1848
Compare
Should this be added for |
If it's opt-in, probably yes 👍 |
3b7d4b7
to
21cb02d
Compare
11ca242
to
69f8295
Compare
@@ -85,7 +88,7 @@ async def select( | |||
""" | |||
try: | |||
if flags["list"]: | |||
await show(project, extractor, show_all=flags["all"]) | |||
await show(project, extractor, install_plugins, show_all=flags["all"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to ignore missing coverage for this for now. We have an incoming test that'll cover this in #8518.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I was about to ask if you wanted a test 😅
Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com>
Implements just-in-time install for the following commands:
invoke
run
el
/elt
test
config <plugin> test
select --list