Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mypy #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add mypy #188

wants to merge 1 commit into from

Conversation

LevUdaltsov
Copy link
Contributor

Adds mypy to the squirrel-core project

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

AlirezaSohofi
AlirezaSohofi reviewed Mar 22, 2024
View reviewed changes
squirrel/artifact_manager/base.py
self.download_artifact(artifact_name, collection, to=to)
if artifact.metadata:
artifact_name = artifact.metadata["artifact"]
self.download_artifact(artifact_name, collection, to=to)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs else with descriptive error message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added logging

squirrel/artifact_manager/drivers.py Outdated Show resolved Hide resolved
squirrel/artifact_manager/filesystem.py Show resolved Hide resolved
squirrel/artifact_manager/wandb.py Show resolved Hide resolved
squirrel/catalog/source.py Show resolved Hide resolved
squirrel/driver/data_frame.py Show resolved Hide resolved
squirrel/driver/driver.py Show resolved Hide resolved
test/integration_test/conftest.py Outdated Show resolved Hide resolved
@LevUdaltsov LevUdaltsov changed the title [WIP] add mypy add mypy Apr 8, 2024
@LevUdaltsov
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Apr 8, 2024
@github-actions
@LevUdaltsov has signed the CLA from Pull Request #188
7e15623
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

This is PR is marked as stale as it has been inactive for 30 days. It will be closed in 7 days.

@LevUdaltsov
add mypy
e90b83c 
refactor to fix mypy errors

change source type hint

fix typing

undo fixture refactor

undo test refactor

small cleanup

debugging

fix tests

add ignores for integration tests, update store property

fix import

remove debugging

undo breaking change

fix composable

resolve poetry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlirezaSohofi AlirezaSohofi AlirezaSohofi left review comments

@mg515 mg515 Awaiting requested review from mg515

@maik-schmidt maik-schmidt Awaiting requested review from maik-schmidt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LevUdaltsov @AlirezaSohofi