Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info icon design update #42557

Merged
merged 17 commits into from
May 15, 2024
Merged

Info icon design update #42557

merged 17 commits into from
May 15, 2024

Conversation

romeovs
Copy link
Contributor

@romeovs romeovs commented May 13, 2024

Closes #42589

Description

Moves the info icon to the column/table icon where applicable.

Demo

Screenshot 2024-05-13 at 12 03 29 Screenshot 2024-05-13 at 12 03 37 Screenshot 2024-05-13 at 12 03 52 Screenshot 2024-05-13 at 12 04 25 Screenshot 2024-05-13 at 12 04 37 Screenshot 2024-05-13 at 12 04 44 Screenshot 2024-05-13 at 12 05 13 Screenshot 2024-05-13 at 12 05 34

@romeovs romeovs added no-backport Do not backport this PR to any branch .Team/QueryingComponents labels May 13, 2024
@romeovs romeovs requested a review from mazameli May 13, 2024 10:06
@romeovs romeovs self-assigned this May 13, 2024
@romeovs romeovs closed this May 13, 2024
@romeovs
Copy link
Contributor Author

romeovs commented May 13, 2024

@mazameli Could you have a look?

Copy link

replay-io bot commented May 13, 2024

Status Complete ↗︎
Commit ce4b96c
Results
⚠️ 3 Flaky
2505 Passed

@romeovs romeovs reopened this May 13, 2024
@romeovs romeovs changed the title [WIP] Info icon design update Info icon design update May 13, 2024
@romeovs romeovs requested a review from a team May 13, 2024 15:34
Copy link
Contributor

@mazameli mazameli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great!

Copy link
Contributor

@kamilmielnik kamilmielnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kamilmielnik kamilmielnik requested a review from a team May 14, 2024 07:42
@romeovs romeovs merged commit 214a598 into master May 15, 2024
111 checks passed
@romeovs romeovs deleted the info-icon-design-update branch May 15, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design update for column info
3 participants