Recents API Improvements #42660
Merged
Recents API Improvements #42660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- just doesn't return them.
- Still need to check for the model_object due to popular-items calls
memoize get-parent-coll
|
…e/metabase into bcm-recents-api-perf-improvement
escherize
commented
May 14, 2024
noahmoss
approved these changes
May 15, 2024
|
I'm converting this to a draft until I include the improved parent_collection support |
- always return effective parent collections
noahmoss
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41957
Fixes #42665
This addresses an opportunity @dpsutton mentioned about improving endpoint's performance.
Main entrypoint is
recent-views/get-list.So, instead of querying for each model one at a time, we get all of the entity info up front for each recent_view in a query for its type. e.g. all
questionanddatasetids are selected from:model/Card, joined with collection and moderation_review.This data is indexed by model and id, and post-process uses that data structure to look up relevant values to return the
Itemshape.mi/can-read?