Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize getColumnCardinality by using cache correctly #42664

Merged
merged 2 commits into from
May 15, 2024

Conversation

uladzimirdev
Copy link
Contributor

@uladzimirdev uladzimirdev commented May 14, 2024

Use cardinality cache correctly to improve perf of the interactive table rendering

Copy link

github-actions bot commented May 14, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff e9f3f49...be135b9.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/lib/utils.js

@uladzimirdev uladzimirdev added the no-backport Do not backport this PR to any branch label May 14, 2024
Copy link

replay-io bot commented May 14, 2024

Status Complete ↗︎
Commit be135b9
Results
⚠️ 3 Flaky
2505 Passed

@uladzimirdev uladzimirdev enabled auto-merge (squash) May 15, 2024 05:19
@uladzimirdev uladzimirdev merged commit 90f7e62 into master May 15, 2024
112 of 113 checks passed
@uladzimirdev uladzimirdev deleted the table-interactive-rendering-perf-1 branch May 15, 2024 06:01
Copy link

@uladzimirdev Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents visual Run Percy visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants