[Metrics V2] Query processor handle no join strategy #42666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #42462 Make QP preprocessor handle queries referencing metrics in the style of legacy metrics. Enforce various compatibility checks.
|
metamben
requested changes
May 15, 2024
There was a problem hiding this comment.
LGTM, but I have a few questions. Also, I would prefer to have test cases explicitly testing and named for the multi-stage metric execution. I would like to see test showing what happens when expression names in a metric clash with the expression names in the host query.
| ((requiring-resolve 'metabase.query-processor.preprocess/preprocess) | ||
| (lib/query query (:dataset-query card-metadata))))] | ||
| {:query metric-query | ||
| :aggregation (first (lib/aggregations metric-query)) |
There was a problem hiding this comment.
Should this fail if there is not exactly one aggregation?
There was a problem hiding this comment.
I think more than one aggregation should be impossible to build so I think it is safe to assume here.
There was a problem hiding this comment.
I meant, if it should throw. Maybe the > 1 case shouldn't, but then it should log, I guess.
metamben
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42667
Make QP preprocessor handle queries referencing metrics in the style of legacy metrics. Enforce various compatibility checks.