Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix static combo chart crashes when viz settings are invalid #42669

Merged
merged 2 commits into from
May 14, 2024

Conversation

alxnddr
Copy link
Member

@alxnddr alxnddr commented May 14, 2024

Closes #42282

Description

Fixes some static charts crashed on Stats. The reason is that questions have outdated and invalid graph.dimensions and graph.metrics settings which weren't validated with the fallback to defaults in the static viz.

How to verify

The newly added story can be used for the verification since it contains invalid viz settings:

"visualization_settings": {
  "graph.dimensions": ["__CREATED_AT", "__CATEGORY"],
  "graph.metrics": ["__count"]
}

Checklist

  • Tests have been added/updated to cover changes in this PR

@metabase-bot metabase-bot bot added .Team/DashViz Dashboard and Viz team visual Run Percy visual testing labels May 14, 2024
@alxnddr alxnddr requested a review from a team May 14, 2024 22:38
@alxnddr alxnddr added the no-backport Do not backport this PR to any branch label May 14, 2024
@alxnddr alxnddr enabled auto-merge (squash) May 14, 2024 22:48
Copy link

replay-io bot commented May 14, 2024

Status Complete ↗︎
Commit c82b4e5
Results
⚠️ 3 Flaky
2505 Passed

@alxnddr alxnddr merged commit e9f3f49 into master May 14, 2024
129 of 137 checks passed
@alxnddr alxnddr deleted the fix-static-combo-crashes-invalid-viz-settings branch May 14, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/DashViz Dashboard and Viz team visual Run Percy visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dc.js migration] static charts crash on stats
2 participants