Windows fixes #84
Open
Windows fixes #84
+261
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: addictivepixels <addictivepixels@mac.com>
Signed-off-by: addictivepixels <addictivepixels@mac.com>
Signed-off-by: addictivepixels <addictivepixels@mac.com>
Better documentation on top of the Windows fixes Signed-off-by: addictivepixels <addictivepixels@mac.com>
|
@addictivepixels thanks! a few merge conflicts, but @sidroopdaska will review soon o/w. |
|
this doesn't fix windows support as torch.compile is not supported on windows, so fast_inference_utils will need to be reworked |
|
@noita-player, can you assist here? |
|
my hack to run on windows via disabling torch.compile and triton flags resulted in 40sec gen times on a 4080 so IMO windows support should just be blocked by the huge perf wins: triton-lang/triton#1640 pytorch/pytorch#122094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.