Fix typos in README.md #14417
Open
Fix typos in README.md #14417
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tharuka <78165134+tharuka-pavith@users.noreply.github.com>
dlech
reviewed
May 3, 2024
README.md
Outdated
| @@ -19,7 +19,7 @@ Python 3.5 and some select features from later versions). The following core | |||
| datatypes are provided: `str`(including basic Unicode support), `bytes`, | |||
| `bytearray`, `tuple`, `list`, `dict`, `set`, `frozenset`, `array.array`, | |||
| `collections.namedtuple`, classes and instances. Builtin modules include | |||
| `os`, `sys`, `time`, `re`, and `struct`, etc. Select ports have support for | |||
| `os`, `sys`, `time`, `re`, and `struct`, etc. Selected ports have support for | |||
There was a problem hiding this comment.
Maybe more clear to say "Some" or "Certain"?
"Select ports" makes more sense to me than "Selected ports" though.
There was a problem hiding this comment.
Hi! Thanks for the feedback. I agree that Some or Certain could work well here. Some would be a better choice.
Co-authored-by: David Lechner <david@lechnology.com> Signed-off-by: tharuka <78165134+tharuka-pavith@users.noreply.github.com>
Signed-off-by: tharuka <78165134+tharuka-pavith@users.noreply.github.com>
|
I have made following changes according to the feedback given,
Would appreciate another review. @dlech |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the fix addressed in issue #14416. Following changes have been made in README.md,
SelecttoSelectedin the above sentence.referencestoreferencein the above sentence.