-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full fix for installation issue when My Documents on network drive #32799
Full fix for installation issue when My Documents on network drive #32799
Conversation
This comment has been minimized.
This comment has been minimized.
@microsoft-github-policy-service agree company="Microsoft" |
…ps://github.com/drawbyperpetual/PowerToys into dev/ani/better-fix-for-my-docs-on-network-drive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
DllEntry="InstallDSCModuleCA" | ||
/> | ||
|
||
<CustomAction Id="UninstallDSCModule" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question, if Execute is deferred for one of them, why isn't it also for the other one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InstallDSCModuleCA needs to know the location of the install folder to be able to copy the DSC files. For this, I use the getInstallFolder
helper function. This requires a deferred custom action with a separate custom action to set the parameter.
UninstallDSCModuleCA doesn't need this, so I left it as it is (default=Immediate I believe). I suppose it would still work as a deferred custom action, but I would have to retest it :)
Summary of the Pull Request
Full fix for #32341 that works for both per-user and per-machine installs.
PR Checklist
PR Checklist
Detailed Description of the Pull Request / Additional comments
[INSTALL FOLDER]\DSCModules
.[INSTALL FOLDER]\DSCModules
location.Validation Steps Performed
When My Documents is on a network drive (and also when this is not the case),