-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.Net] Set up Name field in OpenAIMessageConnector #2662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet/src/AutoGen.OpenAI/Middleware/OpenAIChatRequestMessageConnector.cs
Show resolved
Hide resolved
dotnet/src/AutoGen.OpenAI/Middleware/OpenAIChatRequestMessageConnector.cs
Outdated
Show resolved
Hide resolved
…onnector.cs Co-authored-by: David Luong <davidluong98@gmail.com>
DavidLuong98
approved these changes
May 16, 2024
jayralencar
pushed a commit
to jayralencar/autogen
that referenced
this pull request
May 28, 2024
* create OpenAI tests project * update * update * add tests * add mroe tests: * update comment * Update dotnet/src/AutoGen.OpenAI/Middleware/OpenAIChatRequestMessageConnector.cs Co-authored-by: David Luong <davidluong98@gmail.com> * Update AutoGen.OpenAI.Tests.csproj * fix build --------- Co-authored-by: David Luong <davidluong98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR changes OpenAIMessageConnector to set up the name field when converting from autogen built-in message type to original openai message type. Plus moving openai agent tests to
AutoGen.OpenAI.Tests
, adding bunch of tests and refactor on OpenAIMessageConnector.Related issue number
#2663
Checks