fix(react-tabster): bump tabster to 7.1.4 to fix useArrowNavigationGroup with non-modal Dialog #31413

mshoho · 2024-05-17T18:24:11Z

CHANGELOG https://github.com/microsoft/tabster/blob/master/CHANGELOG.md#v713
including fix for Restorer steals focus from non-modal modals when trigger is inside of arrow navigation group tabster#374.

change/@fluentui-react-tabster-37512240-5808-4174-96b6-a8c571eead67.json

codesandbox-ci · 2024-05-17T18:36:06Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam · 2024-05-17T18:37:09Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	639	646	5000
Button	mount	315	296	5000
Field	mount	1122	1130	5000
FluentProvider	mount	697	701	5000
FluentProviderWithTheme	mount	84	82	10
FluentProviderWithTheme	virtual-rerender	36	39	10
FluentProviderWithTheme	virtual-rerender-with-unmount	79	77	10
MakeStyles	mount	882	867	50000
Persona	mount	1756	1757	5000
SpinButton	mount	1366	1356	5000
SwatchPicker	mount	1550	1551	5000

fabricteam · 2024-05-17T18:37:43Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AvatarMinimalPerf.default	113	105	1.08:1
ChatDuplicateMessagesPerf.default	157	146	1.08:1
ProviderMinimalPerf.default	207	192	1.08:1
AttachmentMinimalPerf.default	85	80	1.06:1
ImageMinimalPerf.default	223	210	1.06:1
CarouselMinimalPerf.default	261	249	1.05:1
DropdownManyItemsPerf.default	396	377	1.05:1
ButtonSlotsPerf.default	319	306	1.04:1
DividerMinimalPerf.default	204	196	1.04:1
HeaderMinimalPerf.default	213	204	1.04:1
ToolbarMinimalPerf.default	546	525	1.04:1
ChatMinimalPerf.default	448	436	1.03:1
FlexMinimalPerf.default	159	155	1.03:1
InputMinimalPerf.default	561	545	1.03:1
MenuMinimalPerf.default	524	508	1.03:1
PopupMinimalPerf.default	352	341	1.03:1
RadioGroupMinimalPerf.default	269	260	1.03:1
ReactionMinimalPerf.default	214	207	1.03:1
StatusMinimalPerf.default	390	380	1.03:1
TextMinimalPerf.default	198	192	1.03:1
CheckboxMinimalPerf.default	1158	1139	1.02:1
DatepickerMinimalPerf.default	3737	3678	1.02:1
DialogMinimalPerf.default	453	443	1.02:1
LabelMinimalPerf.default	224	219	1.02:1
ListCommonPerf.default	402	395	1.02:1
ListMinimalPerf.default	312	305	1.02:1
SegmentMinimalPerf.default	196	192	1.02:1
TableMinimalPerf.default	226	222	1.02:1
VideoMinimalPerf.default	440	431	1.02:1
AccordionMinimalPerf.default	87	86	1.01:1
AnimationMinimalPerf.default	304	302	1.01:1
AttachmentSlotsPerf.default	626	621	1.01:1
GridMinimalPerf.default	190	189	1.01:1
ListNestedPerf.default	327	324	1.01:1
SkeletonMinimalPerf.default	205	203	1.01:1
SliderMinimalPerf.default	761	754	1.01:1
SplitButtonMinimalPerf.default	2290	2258	1.01:1
CustomToolbarPrototype.default	1492	1477	1.01:1
BoxMinimalPerf.default	187	187	1:1
DropdownMinimalPerf.default	1409	1410	1:1
ListWith60ListItems.default	373	372	1:1
RefMinimalPerf.default	110	110	1:1
TooltipMinimalPerf.default	1257	1255	1:1
TreeMinimalPerf.default	480	481	1:1
ButtonMinimalPerf.default	86	87	0.99:1
CardMinimalPerf.default	303	307	0.99:1
ChatWithPopoverPerf.default	193	194	0.99:1
EmbedMinimalPerf.default	1919	1929	0.99:1
ItemLayoutMinimalPerf.default	700	705	0.99:1
MenuButtonMinimalPerf.default	945	958	0.99:1
ProviderMergeThemesPerf.default	634	641	0.99:1
IconMinimalPerf.default	388	393	0.99:1
TableManyItemsPerf.default	1116	1123	0.99:1
TextAreaMinimalPerf.default	279	282	0.99:1
FormMinimalPerf.default	226	231	0.98:1
LoaderMinimalPerf.default	190	194	0.98:1
PortalMinimalPerf.default	80	82	0.98:1
AlertMinimalPerf.default	160	165	0.97:1
ButtonOverridesMissPerf.default	648	665	0.97:1
HeaderSlotsPerf.default	470	488	0.96:1
LayoutMinimalPerf.default	199	207	0.96:1
RosterPerf.default	1497	1591	0.94:1
TreeWith60ListItems.default	85	93	0.91:1

change/@fluentui-react-tabster-37512240-5808-4174-96b6-a8c571eead67.json

fabricteam · 2024-05-17T18:42:12Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2024-05-17T18:44:41Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`react-accordion` Accordion (including children components)	`101.791 kB` `30.819 kB`	`101.807 kB` `30.826 kB`	`16 B` `7 B`
`react-breadcrumb` @fluentui/react-breadcrumb - package	`117.668 kB` `32.416 kB`	`117.684 kB` `32.424 kB`	`16 B` `8 B`
`react-calendar-compat` Calendar Compat	`154.849 kB` `40.324 kB`	`154.865 kB` `40.333 kB`	`16 B` `9 B`
`react-card` Card - All	`104.845 kB` `29.585 kB`	`104.861 kB` `29.591 kB`	`16 B` `6 B`
`react-card` Card	`97.858 kB` `27.837 kB`	`97.874 kB` `27.843 kB`	`16 B` `6 B`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`222.188 kB` `62.744 kB`	`222.204 kB` `62.75 kB`	`16 B` `6 B`
`react-components` react-components: entire library	`1.166 MB` `280.355 kB`	`1.166 MB` `280.362 kB`	`16 B` `7 B`
`react-datepicker-compat` DatePicker Compat	`228.881 kB` `63.703 kB`	`228.897 kB` `63.71 kB`	`16 B` `7 B`
`react-dialog` Dialog (including children components)	`100.597 kB` `30.053 kB`	`100.613 kB` `30.059 kB`	`16 B` `6 B`
`react-menu` Menu (including children components)	`154.746 kB` `46.327 kB`	`154.762 kB` `46.333 kB`	`16 B` `6 B`
`react-menu` Menu (including selectable components)	`157.432 kB` `46.888 kB`	`157.448 kB` `46.895 kB`	`16 B` `7 B`
`react-popover` Popover	`129.074 kB` `40.438 kB`	`129.09 kB` `40.444 kB`	`16 B` `6 B`
`react-swatch-picker` @fluentui/react-swatch-picker - package	`110.047 kB` `30.74 kB`	`110.063 kB` `30.747 kB`	`16 B` `7 B`
`react-table` DataGrid	`169.681 kB` `47.067 kB`	`169.697 kB` `47.073 kB`	`16 B` `6 B`
`react-table` Table as DataGrid	`138.765 kB` `37.41 kB`	`138.781 kB` `37.418 kB`	`16 B` `8 B`
`react-tag-picker` @fluentui/react-tag-picker - package	`189.079 kB` `55.943 kB`	`189.095 kB` `55.95 kB`	`16 B` `7 B`
`react-tags` TagGroup	`82.895 kB` `24.635 kB`	`82.911 kB` `24.642 kB`	`16 B` `7 B`
`react-toast` Toast (including Toaster)	`99.518 kB` `30.001 kB`	`99.534 kB` `30.008 kB`	`16 B` `7 B`

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `328 B`
`global-context` createContextSelector	`537 B` `339 B`
`keyboard-key` keyboard-key package	`3.746 kB` `1.928 kB`
`priority-overflow` createOverflowManager	`4.457 kB` `1.856 kB`
`react` ActivityItem	`71.019 kB` `23.288 kB`
`react` Announced	`38.291 kB` `13.239 kB`
`react` Autofill	`15.365 kB` `4.743 kB`
`react` Breadcrumb	`201.796 kB` `60.267 kB`
`react` Button	`195.26 kB` `56.471 kB`
`react` ButtonGrid	`180.207 kB` `54.515 kB`
`react` Calendar	`121.542 kB` `36.943 kB`
`react` Callout	`84.108 kB` `27.552 kB`
`react` Check	`52.963 kB` `17.773 kB`
`react` Checkbox	`59.751 kB` `19.806 kB`
`react` ChoiceGroup	`65.276 kB` `21.438 kB`
`react` ChoiceGroupOption	`58.531 kB` `19.309 kB`
`react` Coachmark	`92.937 kB` `29.356 kB`
`react` Color	`7.737 kB` `3.106 kB`
`react` ColorPicker	`132.985 kB` `41.502 kB`
`react` ComboBox	`251.561 kB` `72.081 kB`
`react` CommandBar	`202.829 kB` `59.975 kB`
`react` ContextualMenu	`154.789 kB` `48.068 kB`
`react` DatePicker	`183.939 kB` `56.079 kB`
`react` DateTimeUtilities	`5.244 kB` `1.849 kB`
`react` DetailsList	`229.317 kB` `65.63 kB`
`react` Dialog	`211.12 kB` `62.982 kB`
`react` Divider	`19.399 kB` `6.798 kB`
`react` DocumentCard	`216.805 kB` `64.269 kB`
`react` DragDrop	`8.343 kB` `2.724 kB`
`react` DraggableZone	`34.109 kB` `11.448 kB`
`react` Dropdown	`233.726 kB` `68.456 kB`
`react` ExtendedPicker	`96.565 kB` `27.809 kB`
`react` Fabric	`41.537 kB` `14.283 kB`
`react` Facepile	`210.377 kB` `63.035 kB`
`react` FloatingPicker	`241.851 kB` `68.827 kB`
`react` FocusTrapZone	`16.975 kB` `5.917 kB`
`react` FocusZone	`54.844 kB` `17.402 kB`
`react` Grid	`180.207 kB` `54.515 kB`
`react` GroupedList	`134.634 kB` `40.596 kB`
`react` GroupedListV2	`122.251 kB` `37.703 kB`
`react` HoverCard	`96.969 kB` `30.741 kB`
`react` Icon	`51.644 kB` `17.197 kB`
`react` Icons	`66.305 kB` `24.379 kB`
`react` Image	`46.701 kB` `15.646 kB`
`react` Keytip	`81.482 kB` `26.712 kB`
`react` KeytipData	`13.969 kB` `4.57 kB`
`react` KeytipLayer	`103.278 kB` `31.961 kB`
`react` Keytips	`106.046 kB` `32.966 kB`
`react` Label	`38.134 kB` `13.207 kB`
`react` Layer	`47.887 kB` `16.295 kB`
`react` Link	`39.488 kB` `13.614 kB`
`react` List	`39.176 kB` `12.384 kB`
`react` MarqueeSelection	`74.321 kB` `22.385 kB`
`react` MessageBar	`190.311 kB` `56.941 kB`
`react` Modal	`93.44 kB` `30.18 kB`
`react` Nav	`187.789 kB` `56.378 kB`
`react` OverflowSet	`33.191 kB` `11.252 kB`
`react` Overlay	`40.694 kB` `14.023 kB`
`react` Panel	`200.831 kB` `59.888 kB`
`react` Persona	`114.617 kB` `36.442 kB`
`react` PersonaCoin	`114.617 kB` `36.442 kB`
`react` PersonaPresence	`57.833 kB` `19.303 kB`
`react` Pickers	`293.537 kB` `82.173 kB`
`react` Pivot	`188.703 kB` `57.114 kB`
`react` Popup	`12.242 kB` `4.181 kB`
`react` Positioning	`22.608 kB` `7.63 kB`
`react` PositioningContainer	`73.643 kB` `23.706 kB`
`react` ProgressIndicator	`39.286 kB` `13.482 kB`
`react` Rating	`81.762 kB` `26.057 kB`
`react` Fluent UI React (entire library)	`1.013 MB` `281.289 kB`
`react` ResizeGroup	`13.286 kB` `4.365 kB`
`react` ResponsiveMode	`8.078 kB` `2.95 kB`
`react` ScrollablePane	`55.325 kB` `17.669 kB`
`react` SearchBox	`188.586 kB` `56.544 kB`
`react` SelectableOption	`724 B` `413 B`
`react` SelectedItemsList	`232.346 kB` `67.779 kB`
`react` Selection	`42.252 kB` `12.203 kB`
`react` Separator	`35.183 kB` `12.088 kB`
`react` Shimmer	`49.049 kB` `16.206 kB`
`react` ShimmeredDetailsList	`240.092 kB` `68.397 kB`
`react` Slider	`57.449 kB` `19.143 kB`
`react` SpinButton	`192.314 kB` `57.665 kB`
`react` Spinner	`41.481 kB` `14.412 kB`
`react` Stack	`41.547 kB` `14.233 kB`
`react` Sticky	`32.541 kB` `10.49 kB`
`react` Styling	`45.853 kB` `15.082 kB`
`react` SwatchColorPicker	`190.533 kB` `57.999 kB`
`react` TeachingBubble	`205.586 kB` `60.896 kB`
`react` Text	`36.723 kB` `12.763 kB`
`react` TextField	`80.555 kB` `25.262 kB`
`react` Theme	`43.321 kB` `14.129 kB`
`react` ThemeGenerator	`12.34 kB` `4.106 kB`
`react` TimePicker	`241.365 kB` `69.856 kB`
`react` Toggle	`46.02 kB` `15.903 kB`
`react` Tooltip	`87.136 kB` `28.164 kB`
`react` Utilities	`82.495 kB` `25.047 kB`
`react` Viewport	`23.703 kB` `7.589 kB`
`react` WeeklyDayPicker	`101.682 kB` `31.738 kB`
`react` WindowProvider	`1.059 kB` `541 B`
`react-alert` Alert	`84.099 kB` `23.645 kB`
`react-avatar` Avatar	`50.537 kB` `16.11 kB`
`react-avatar` AvatarGroup	`20.107 kB` `7.973 kB`
`react-avatar` AvatarGroupItem	`65.191 kB` `20.441 kB`
`react-badge` Badge	`27.31 kB` `8.901 kB`
`react-badge` CounterBadge	`28.214 kB` `9.202 kB`
`react-badge` PresenceBadge	`25.717 kB` `9.483 kB`
`react-button` Button	`39.917 kB` `11.339 kB`
`react-button` CompoundButton	`47.278 kB` `12.834 kB`
`react-button` MenuButton	`44.698 kB` `12.729 kB`
`react-button` SplitButton	`52.71 kB` `14.313 kB`
`react-button` ToggleButton	`56.963 kB` `13.243 kB`
`react-card` CardFooter	`14.375 kB` `5.796 kB`
`react-card` CardHeader	`16.618 kB` `6.555 kB`
`react-card` CardPreview	`14.418 kB` `5.931 kB`
`react-checkbox` Checkbox	`36.506 kB` `12.305 kB`
`react-combobox` Combobox (including child components)	`106.032 kB` `34.071 kB`
`react-combobox` Dropdown (including child components)	`107.447 kB` `34.045 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`71.955 kB` `20.772 kB`
`react-components` react-components: FluentProvider & webLightTheme	`44.442 kB` `14.607 kB`
`react-divider` Divider	`21.326 kB` `7.963 kB`
`react-field` Field	`23.382 kB` `8.901 kB`
`react-image` Image	`16.15 kB` `6.407 kB`
`react-input` Input	`28.444 kB` `9.526 kB`
`react-jsx-runtime` Classic Pragma	`1.057 kB` `530 B`
`react-jsx-runtime` JSX Dev Runtime	`3.781 kB` `1.646 kB`
`react-jsx-runtime` JSX Runtime	`4.377 kB` `1.881 kB`
`react-label` Label	`14.67 kB` `6 kB`
`react-link` Link	`17.466 kB` `7.079 kB`
`react-message-bar` MessageBar (all components)	`24.608 kB` `9.155 kB`
`react-northstar` Accordion	`85.392 kB` `26.518 kB`
`react-northstar` Alert	`87.45 kB` `26.902 kB`
`react-northstar` Animation	`55.34 kB` `17.829 kB`
`react-northstar` Attachment	`86.844 kB` `26.692 kB`
`react-northstar` Avatar	`80.279 kB` `24.629 kB`
`react-northstar` Box	`75.248 kB` `23.806 kB`
`react-northstar` Breadcrumb	`79.92 kB` `24.709 kB`
`react-northstar` Button	`83.16 kB` `25.947 kB`
`react-northstar` Card	`82.705 kB` `25.023 kB`
`react-northstar` Carousel	`105.182 kB` `31.871 kB`
`react-northstar` Chat	`152.378 kB` `45.964 kB`
`react-northstar` Checkbox	`79.807 kB` `25.078 kB`
`react-northstar` Datepicker	`184.939 kB` `56.194 kB`
`react-northstar` Debug	`8.801 kB` `3.594 kB`
`react-northstar` Design	`36.589 kB` `12.067 kB`
`react-northstar` Dialog	`112.058 kB` `33.615 kB`
`react-northstar` Divider	`76.619 kB` `24.129 kB`
`react-northstar` Dropdown	`196.499 kB` `59.455 kB`
`react-northstar` Embed	`81.477 kB` `25.417 kB`
`react-northstar` Flex	`47.728 kB` `15.438 kB`
`react-northstar` Form	`92.527 kB` `28.879 kB`
`react-northstar` Grid	`70.584 kB` `22.278 kB`
`react-northstar` Header	`74.756 kB` `23.461 kB`
`react-northstar` Image	`73.591 kB` `23.329 kB`
`react-northstar` Input	`88.346 kB` `27.78 kB`
`react-northstar` ItemLayout	`78.231 kB` `24.454 kB`
`react-northstar` Label	`77.92 kB` `24.41 kB`
`react-northstar` Layout	`75.393 kB` `23.798 kB`
`react-northstar` List	`88.493 kB` `27.547 kB`
`react-northstar` Loader	`78.616 kB` `24.729 kB`
`react-northstar` Menu	`126.89 kB` `39.872 kB`
`react-northstar` MenuButton	`161.296 kB` `48.883 kB`
`react-northstar` Pill	`83.722 kB` `26.069 kB`
`react-northstar` Popup	`133.604 kB` `41.483 kB`
`react-northstar` Portal	`58.338 kB` `18.852 kB`
`react-northstar` Provider	`93.138 kB` `29.63 kB`
`react-northstar` RadioGroup	`83.282 kB` `26.053 kB`
`react-northstar` Reaction	`77.28 kB` `24.122 kB`
`react-northstar` Segment	`76.209 kB` `23.892 kB`
`react-northstar` Skeleton	`77.765 kB` `24.2 kB`
`react-northstar` Slider	`84.27 kB` `26.737 kB`
`react-northstar` SplitButton	`176.534 kB` `52.63 kB`
`react-northstar` Status	`76.272 kB` `24.05 kB`
`react-northstar` SvgIcon	`36.823 kB` `11.743 kB`
`react-northstar` Table	`80.796 kB` `25.154 kB`
`react-northstar` Text	`74.114 kB` `23.507 kB`
`react-northstar` TextArea	`74.248 kB` `23.492 kB`
`react-northstar` Toolbar	`173.345 kB` `52.08 kB`
`react-northstar` Tooltip	`108.261 kB` `34.482 kB`
`react-northstar` Tree	`87.855 kB` `27.217 kB`
`react-northstar` Video	`75.411 kB` `23.799 kB`
`react-overflow` hooks only	`12.87 kB` `4.83 kB`
`react-persona` Persona	`57.428 kB` `17.99 kB`
`react-portal` Portal	`14.563 kB` `5.118 kB`
`react-portal-compat` PortalCompatProvider	`8.39 kB` `2.64 kB`
`react-positioning` usePositioning	`26.489 kB` `9.552 kB`
`react-progress` ProgressBar	`17.833 kB` `7.074 kB`
`react-provider` FluentProvider	`24.616 kB` `8.903 kB`
`react-radio` Radio	`33.802 kB` `10.485 kB`
`react-radio` RadioGroup	`15.758 kB` `6.431 kB`
`react-select` Select	`28.997 kB` `10.374 kB`
`react-slider` Slider	`40.8 kB` `13.201 kB`
`react-spinbutton` SpinButton	`37.101 kB` `11.955 kB`
`react-spinner` Spinner	`25.134 kB` `8.521 kB`
`react-switch` Switch	`36.444 kB` `11.48 kB`
`react-table` Table (Primitives only)	`46.175 kB` `14.35 kB`
`react-table` Table (Selection only)	`77.181 kB` `20.767 kB`
`react-table` Table (Sort only)	`75.824 kB` `20.369 kB`
`react-tags` InteractionTag	`15.703 kB` `6.253 kB`
`react-tags` Tag	`29.408 kB` `9.593 kB`
`react-text` Text - Default	`17.11 kB` `6.744 kB`
`react-text` Text - Wrappers	`20.282 kB` `7.074 kB`
`react-textarea` Textarea	`31.351 kB` `10.651 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`35.666 kB` `7.453 kB`
`react-theme` Teams: Light theme	`19.642 kB` `5.549 kB`
`react-timepicker-compat` TimePicker	`108.051 kB` `35.451 kB`
`react-tooltip` Tooltip	`55.606 kB` `19.444 kB`
`react-utilities` SSRProvider	`180 B` `160 B`

_{🤖 This report was generated against 4a31dd954eeb298a67e592aac096e27843626616}

fabricteam · 2024-05-17T18:51:04Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	644	629	5000
Breadcrumb	mount	1733	1711	1000
Checkbox	mount	1702	1738	5000
CheckboxBase	mount	1515	1518	5000
ChoiceGroup	mount	3034	3047	5000
ComboBox	mount	664	691	1000
CommandBar	mount	6858	6733	1000
ContextualMenu	mount	16419	16712	1000
DefaultButton	mount	807	817	5000
DetailsRow	mount	2255	2280	5000
DetailsRowFast	mount	2277	2259	5000
DetailsRowNoStyles	mount	2071	2050	5000
Dialog	mount	2684	2659	1000
DocumentCardTitle	mount	238	244	1000
Dropdown	mount	2029	2043	5000
FocusTrapZone	mount	1172	1152	5000
FocusZone	mount	1126	1102	5000
GroupedList	mount	42921	43514	2
GroupedList	virtual-rerender	20553	20479	2
GroupedList	virtual-rerender-with-unmount	54606	52665	2
GroupedListV2	mount	226	236	2
GroupedListV2	virtual-rerender	221	223	2
GroupedListV2	virtual-rerender-with-unmount	238	244	2
IconButton	mount	1138	1118	5000
Label	mount	353	353	5000
Layer	mount	2797	2818	5000
Link	mount	394	404	5000
MenuButton	mount	1010	998	5000
MessageBar	mount	21662	21508	5000
Nav	mount	2080	2082	1000
OverflowSet	mount	800	808	5000
Panel	mount	1854	1780	1000
Persona	mount	743	785	1000
Pivot	mount	937	892	1000
PrimaryButton	mount	926	961	5000
Rating	mount	4678	4715	5000
SearchBox	mount	940	935	5000
Shimmer	mount	1952	1944	5000
Slider	mount	1356	1392	5000
SpinButton	mount	2989	3040	5000
Spinner	mount	407	404	5000
SplitButton	mount	1877	1855	5000
Stack	mount	400	426	5000
StackWithIntrinsicChildren	mount	845	873	5000
StackWithTextChildren	mount	2707	2687	5000
SwatchColorPicker	mount	6440	6494	5000
TagPicker	mount	1480	1524	5000
Text	mount	383	373	5000
TextField	mount	925	955	5000
ThemeProvider	mount	865	872	5000
ThemeProvider	virtual-rerender	580	595	5000
ThemeProvider	virtual-rerender-with-unmount	1307	1279	5000
Toggle	mount	641	631	5000
buttonNative	mount	197	202	5000

change/@fluentui-react-tabster-37512240-5808-4174-96b6-a8c571eead67.json

Hotell · 2024-05-21T13:59:35Z

@mshoho I updated PR title and PR description to follow our practices. Please follow that pattern next time. ty

Hotell · 2024-05-21T14:05:45Z

@mshoho are you sure that PR of yours is making sure that everything else works as before ?

https://github.com/microsoft/tabster/pull/389/files#diff-6409ffc3151e5ba314facd27fff9dbbe4b92d21cd9c976ab0c683c2acf55de32R3016

that .only 🚨 doesn't look very trustworthy

Hotell

need author feedback

…ead67.json Co-authored-by: Martin Hochel <hochelmartin@gmail.com>

…se tests are green.

mshoho · 2024-05-21T17:30:16Z

@mshoho are you sure that PR of yours is making sure that everything else works as before ?

https://github.com/microsoft/tabster/pull/389/files#diff-6409ffc3151e5ba314facd27fff9dbbe4b92d21cd9c976ab0c683c2acf55de32R3016

that .only 🚨 doesn't look very trustworthy

Thanks for the good catch. I have removed .only() and rereleased, the tests are still green, bumped the version in the PR to 7.1.4 with .only() removed.

fabricteam · 2024-05-21T17:56:26Z

🕵 fluentuiv9 No visual regressions between this PR and main

mshoho added 2 commits May 17, 2024 20:21

Bumping Tabster to 7.1.3.

9b9c111

Change files.

5508ff9

mshoho requested review from a team as code owners May 17, 2024 18:24

mshoho changed the title ~~Tabster 7.1.3~~ Tabster 7.1.3 to fix useArrowNavigationGroup with non-modal Dialog May 17, 2024

fabricteam reviewed May 17, 2024

View reviewed changes

change/@fluentui-react-tabster-37512240-5808-4174-96b6-a8c571eead67.json Show resolved Hide resolved

fabricteam reviewed May 17, 2024

View reviewed changes

change/@fluentui-react-tabster-37512240-5808-4174-96b6-a8c571eead67.json Show resolved Hide resolved

micahgodbolt approved these changes May 17, 2024

View reviewed changes

tudorpopams requested review from Hotell and marcosmoura and removed request for Hotell May 21, 2024 12:06

Hotell reviewed May 21, 2024

View reviewed changes

change/@fluentui-react-tabster-37512240-5808-4174-96b6-a8c571eead67.json Outdated Show resolved Hide resolved

Hotell changed the title ~~Tabster 7.1.3 to fix useArrowNavigationGroup with non-modal Dialog~~ fix(react-tabster): bump tabster to 7.1.3 to fix useArrowNavigationGroup with non-modal Dialog May 21, 2024

Hotell requested changes May 21, 2024

View reviewed changes

microsoft-github-policy-service bot added the Needs: Author Feedback label May 21, 2024

Update change/@fluentui-react-tabster-37512240-5808-4174-96b6-a8c571e…

d2441c8

…ead67.json Co-authored-by: Martin Hochel <hochelmartin@gmail.com>

microsoft-github-policy-service bot removed the Needs: Author Feedback label May 21, 2024

Pulling Tabster 7.1.4 to ensure all the skipped in the previous relea…

56debcc

…se tests are green.

mshoho changed the title ~~fix(react-tabster): bump tabster to 7.1.3 to fix useArrowNavigationGroup with non-modal Dialog~~ fix(react-tabster): bump tabster to 7.1.4 to fix useArrowNavigationGroup with non-modal Dialog May 21, 2024

mshoho requested a review from Hotell May 22, 2024 11:53

Hotell approved these changes May 22, 2024

View reviewed changes

layershifter approved these changes May 22, 2024

View reviewed changes

mshoho merged commit 7065058 into microsoft:master May 22, 2024
22 checks passed

mshoho deleted the tabster-7.1.3 branch May 22, 2024 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(react-tabster): bump tabster to 7.1.4 to fix useArrowNavigationGroup with non-modal Dialog #31413

fix(react-tabster): bump tabster to 7.1.4 to fix useArrowNavigationGroup with non-modal Dialog #31413

mshoho commented May 17, 2024 •

edited by Hotell

codesandbox-ci bot commented May 17, 2024 •

edited

fabricteam commented May 17, 2024 •

edited

fabricteam commented May 17, 2024 •

edited

fabricteam commented May 17, 2024 •

edited

fabricteam commented May 17, 2024 •

edited

fabricteam commented May 17, 2024 •

edited

Hotell commented May 21, 2024

Hotell commented May 21, 2024

Hotell left a comment

mshoho commented May 21, 2024

fabricteam commented May 21, 2024

fix(react-tabster): bump tabster to 7.1.4 to fix useArrowNavigationGroup with non-modal Dialog #31413

fix(react-tabster): bump tabster to 7.1.4 to fix useArrowNavigationGroup with non-modal Dialog #31413

Conversation

mshoho commented May 17, 2024 • edited by Hotell

codesandbox-ci bot commented May 17, 2024 • edited

fabricteam commented May 17, 2024 • edited

Perf Analysis (@fluentui/react-components)

fabricteam commented May 17, 2024 • edited

Perf Analysis (@fluentui/react-northstar)

fabricteam commented May 17, 2024 • edited

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam commented May 17, 2024 • edited

📊 Bundle size report

fabricteam commented May 17, 2024 • edited

Perf Analysis (@fluentui/react)

Hotell commented May 21, 2024

Hotell commented May 21, 2024

Hotell left a comment

Choose a reason for hiding this comment

mshoho commented May 21, 2024

fabricteam commented May 21, 2024

🕵 fluentuiv9 No visual regressions between this PR and main

mshoho commented May 17, 2024 •

edited by Hotell

codesandbox-ci bot commented May 17, 2024 •

edited

fabricteam commented May 17, 2024 •

edited

Perf Analysis (`@fluentui/react-components`)

fabricteam commented May 17, 2024 •

edited

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented May 17, 2024 •

edited

fabricteam commented May 17, 2024 •

edited

fabricteam commented May 17, 2024 •

edited

Perf Analysis (`@fluentui/react`)