Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web-components): simplify compile script, tweak api-extractor config to stop spamming CI with warnings #31422

Merged
merged 2 commits into from
May 22, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented May 20, 2024

Previous Behavior

  • compile does a lot of manual work handled by our task orchestrator

New Behavior

  • to run build command our task orchestrator needs to be used
    • BEFORE: yarn workspace @fluentui/web-components build / this wont work anymore
    • AFTER: yarn lage build --to web-components
  • refactored generate-tokens script to be fully ESM
  • updated api-extractor config to get rid of tons of console warnings

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented May 20, 2024

📊 Bundle size report

✅ No changes found

Copy link

codesandbox-ci bot commented May 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Hotell Hotell marked this pull request as ready for review May 20, 2024 11:06
@Hotell Hotell requested review from a team as code owners May 20, 2024 11:06
@tudorpopams tudorpopams self-requested a review May 21, 2024 12:05
@Hotell Hotell enabled auto-merge (squash) May 22, 2024 09:17
@Hotell Hotell merged commit 051db5e into microsoft:master May 22, 2024
19 checks passed
@Hotell Hotell deleted the wc-3-followup/compile-task branch May 22, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants