-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[folly related] update to 05.13 #38715
Conversation
The following error occurred when cachelib was tested under Linux.
|
The issue is that folly uses See also: #38279 (comment) |
Success build log:
|
Ports folly,fizz,wangle,proxygen,mvfst,fbthrift,cachelib installation test pass under ubuntu with following triplets:
|
Why is this PR marked as dependent on upstream changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch was not accepted upstream. Is the patch required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They decided to address this issue using a different approach, but for now, applying the patch is the easiest option.
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file../vcpkg x-add-version --all
and committing the result.