-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add client interceptor support #900
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: madogar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @madogar! It looks like this is your first PR to milvus-io/milvus-sdk-java 🎉 |
Signed-off-by: Shreesha Srinath Madogaran <smadogaran@salesforce.com>
0b6020a
to
52456fa
Compare
@madogar Java SDK follows the python sdk logic. In python sdk, the interceptor is used to pass db_name and authorization. The python sdk doesn't provide direct interceptor for users, either. We only expose parameters that we can support. |
@yhmo As of today there is no way to set the param from java SDK, hence this change where would implement an interceptor like below and set it at client level:
}` The biggest challenge is setting this (unique value)param for every gRPC call. |
@madogar
We can add a method to the ConnectParam like this:
The ConnectParam.withClientInterceptors() directly exposes the grpc class ClientInterceptor to users, which is not a good design. It might be out of control if users pass ClientInterceptor freely to the server. Just let the user input an ID by |
No description provided.