Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Select L2 segments in L0Compaction as well (#32991) #32992

Closed
wants to merge 1 commit into from

Conversation

bigsheeper
Copy link
Contributor

/kind improvement

pr: #32991

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines. labels May 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (7de9311) to head (ccf364a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #32992      +/-   ##
==========================================
- Coverage   81.86%   81.80%   -0.06%     
==========================================
  Files         992     1001       +9     
  Lines      125609   125368     -241     
==========================================
- Hits       102829   102558     -271     
- Misses      18884    18912      +28     
- Partials     3896     3898       +2     
Files Coverage Δ
internal/datacoord/compaction.go 88.19% <100.00%> (ø)

... and 206 files with indirect coverage changes

Copy link
Contributor

mergify bot commented May 11, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot deleted the branch milvus-io:2.4 May 15, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants