-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: skip return segment/channel info if no changes happens. #33022
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@weiliu1031 E2e jenkins job failed, comment |
caa2cfa
to
74c29a7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33022 +/- ##
==========================================
- Coverage 82.18% 82.09% -0.09%
==========================================
Files 1009 1005 -4
Lines 128806 127681 -1125
==========================================
- Hits 105860 104821 -1039
+ Misses 18953 18894 -59
+ Partials 3993 3966 -27
|
querycoord call getRecoveryInfo to get segment/channel list for every 3s, and it will get same content if no changes happens in datacoord, which will cause a meaningless network and cpu cost. to solve this, we compute md5 signature for segment list, and use this signature to check whether segment list changes, if no changes happens, skip return the segment info in rpc. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
74c29a7
to
bca9662
Compare
/hold |
compute hash for segment id list cost too much cpu |
rerun ut |
issue: #32244
querycoord call getRecoveryInfo to get segment/channel list for every 3s, and it will get same content if no changes happens in datacoord, which will cause a meaningless network and cpu cost.
to solve this, we compute md5 signature for segment list, and use this signature to check whether segment list changes, if no changes happens, skip return the segment info in rpc.