Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Make sure every segment only trigger flush task once by channel.flushTs. #33034

Merged
merged 1 commit into from
May 17, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented May 14, 2024

No description provided.

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 14, 2024
Copy link
Contributor

mergify bot commented May 14, 2024

@aoiasd Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label May 14, 2024
Copy link
Contributor

mergify bot commented May 14, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.13%. Comparing base (bfd8867) to head (1b5f9db).
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #33034   +/-   ##
=======================================
  Coverage   83.12%   83.13%           
=======================================
  Files         850      850           
  Lines      106591   106591           
=======================================
+ Hits        88604    88612    +8     
+ Misses      14689    14684    -5     
+ Partials     3298     3295    -3     
Files Coverage Δ
internal/datanode/segment_sync_policy.go 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

@aoiasd
Copy link
Contributor Author

aoiasd commented May 14, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 14, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented May 16, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 16, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor

LGTM

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia
Copy link
Contributor

/kind branch-feature

@aoiasd
Copy link
Contributor Author

aoiasd commented May 17, 2024

/run-cpu-e2e

@congqixia congqixia added this to the 2.3.16 milestone May 17, 2024
@mergify mergify bot added the ci-passed label May 17, 2024
@sre-ci-robot sre-ci-robot merged commit 62848d3 into milvus-io:2.3 May 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants