Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Enable to dynamic update balancer policy in querycoord #33037

Merged
merged 2 commits into from
May 21, 2024
Merged

enhance: Enable to dynamic update balancer policy in querycoord #33037

merged 2 commits into from
May 21, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #33036
This PR enable to dynamic update balancer policy without restart querycoord.

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the enable_dynamic_update_balancer branch from f04bdc5 to 5646ba7 Compare May 14, 2024 06:46
@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the enable_dynamic_update_balancer branch from 5646ba7 to a8437a1 Compare May 14, 2024 10:17
@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031
enhance: Enable to dynamic update balancer policy in querycoord
74ad839 
This PR enable to dynamic update balancer policy without restart
querycoord.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 force-pushed the enable_dynamic_update_balancer branch from a8437a1 to 74ad839 Compare May 20, 2024 03:11
@weiliu1031
fix create balancer again and again
5f85e37 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2024

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

Attention: Patch coverage is 75.67568% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 82.21%. Comparing base (a7f6193) to head (5f85e37).
Report is 17 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33037      +/-   ##
==========================================
+ Coverage   82.18%   82.21%   +0.02%     
==========================================
  Files        1009     1009              
  Lines      128806   128832      +26     
==========================================
+ Hits       105860   105914      +54     
+ Misses      18953    18925      -28     
  Partials     3993     3993
Files Coverage Δ
internal/querycoordv2/checkers/balance_checker.go 95.12% <100.00%> (ø)
internal/querycoordv2/checkers/channel_checker.go 84.67% <100.00%> (-0.73%) ⬇️
internal/querycoordv2/checkers/controller.go 95.69% <100.00%> (ø)
internal/querycoordv2/checkers/segment_checker.go 88.30% <100.00%> (ø)
internal/querycoordv2/handlers.go 72.07% <100.00%> (-1.51%) ⬇️
internal/querycoordv2/server.go 83.05% <65.38%> (+0.36%) ⬆️

... and 37 files with indirect coverage changes

@sunby
Copy link
Contributor

sunby commented May 21, 2024

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 21, 2024
@sre-ci-robot sre-ci-robot merged commit 2013d97 into milvus-io:master May 21, 2024
14 of 15 checks passed
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label May 21, 2024
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request May 22, 2024
@weiliu1031
enhance: Enable to dynamic update balancer policy in querycoord (milv…
9bc404a 
…us-io#33037)

issue: milvus-io#33036
This PR enable to dynamic update balancer policy without restart
querycoord.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 mentioned this pull request May 22, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request May 23, 2024
@weiliu1031
enhance: Enable to dynamic update balancer policy in querycoord (#33037…
32bfd9b 
…) (#33272)

issue: #33036
pr: #33037
This PR enable to dynamic update balancer policy without restart
querycoord.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@sunby sunby Awaiting requested review from sunby

Assignees

@sunby sunby

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled PR | need cherry-pick need cherry pick to other branches size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@weiliu1031 @sunby @congqixia @sre-ci-robot @czs007 @yanliang567