Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asyncio support #1273

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Asyncio support #1273

wants to merge 7 commits into from

Conversation

belkka
Copy link

@belkka belkka commented Jan 31, 2023 •
edited

Commits with commit message "draft" will be overridden, so ignore formatting/style issues in those commits.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: belkka
To complete the pull request process, please assign longjiquan after the PR has been reviewed.
You can assign the PR to them by writing /assign @longjiquan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link

Welcome @belkka! It looks like this is your first PR to milvus-io/pymilvus 🎉

@mergify mergify bot added the needs-dco label Jan 31, 2023
@belkka
Copy link
Author

belkka commented Jan 31, 2023

Started moving reusable parts of GrpcHandler into AbstractGrpcHandler.

@belkka
fixup grpc_handler
61e2041
@belkka
Update Connections.remove_connection()
a3e457e 
milvus-io#1273 (comment)
@belkka
Add AbstractCollection
044f053
@belkka
Add async Collection with several methods
f65169b 
Add a test case that invokes
insert, create_index, load, search methods
(from original Collection docstring).
@mistborn17
Copy link

Just to followup, I'm interested in the asyncio support for pymilvus. Is this PR still relevant ?

@belkka
Copy link
Author

belkka commented Sep 15, 2023

@mistborn17 I stopped working on this PR when suddenly noticed https://github.com/milvus-io/pymilvus/pull/1288/files, which adds "deprecation" markings on code that is being "adapted" for asyncio in this PR (e. g. pymilvus.orm.collection.Collection). I had some communication on this topic in slack (milvusio.slack.com), but now it does not let me read messages older than 90 days. IIRC, they said they are working on new API (in a separate branch) and they are gonna provide asyncio interface in that API (but maybe not full support/test coverage).

@belkka belkka changed the title [WIP] Asyncio support Asyncio support Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew-Chen-Wang Andrew-Chen-Wang Andrew-Chen-Wang left review comments

@filip-halt filip-halt filip-halt left review comments

@longjiquan longjiquan Awaiting requested review from longjiquan

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees
No one assigned
Labels
needs-dco size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@belkka @sre-ci-robot @mistborn17 @Andrew-Chen-Wang @filip-halt