-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to cancel async jobs #14602
Open
y5nw
wants to merge
24
commits into
minetest:master
Choose a base branch
from
y5nw:async-canceling
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add API to cancel async jobs #14602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some thoughts
I almost forgot: should this feature also be available for the main menu environment? |
No need atm. If someone needs it in the future, they can add it. |
sfan5
reviewed
Jun 3, 2024
sfan5
reviewed
Jun 3, 2024
y5nw
changed the title
Add API to replace an existing async job
Add API to cancel async jobs
Jun 3, 2024
sfan5
reviewed
Jun 4, 2024
sfan5
reviewed
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Concept approved
Approved by a core dev: PRs welcomed!
Feature ✨
PRs that add or enhance a feature
@ Script API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an API to cancel async jobs.
See above
The async engine attempts to remove jobs from the queue if it is not yet executed.
Partially addresses No proper way to deal with async job interdependencies / no cancellation #13681
See linked issue.
See linked issue.
To do
This PR is a Work in Progress.
Implement replacing jobs(Dropped)Replacing jobs before the job is run(Dropped)Replacing jobs after the job is complete(Dropped)How to test
The new API should be covered by unittests.
Note that I have not yet figured out how to test certain things mentioned in the PR, such as canceling existing async jobs on shutdown.