Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some clang compiler warnings #14654

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

appgurueu
Copy link
Contributor

@appgurueu appgurueu commented May 14, 2024

To do

This PR is Ready for Review.

How to test

Compile with clang, enjoy the absence of warnings.

@appgurueu appgurueu added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label May 14, 2024
@sfan5
Copy link
Member

sfan5 commented May 14, 2024

However I'm not really sure what the logic here is - why is a runtime version check necessary at all; why doesn't the compile time version check suffice?

I agree. While it's theoretically possible to compile applications using a new SDL version and then load an older one at runtime, nobody does this and it shouldn't be supported.

Discontinues support for dynamically linking against an older SDL version
@sfan5 sfan5 merged commit 5c18736 into minetest:master May 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants