fix: Added dedicated error handling to load and get_model_path #775
Conversation
Added proper error handling to load and get_model_path by adding a dedicated exception class, because when the local path is not right, it still throws the huggingface RepositoryNotFoundError
llms/mlx_lm/utils.py
Outdated
| except RepositoryNotFoundError: | ||
| raise RepoNotFoundError(f"No local or Hugging Face repository found for path: {path_or_hf_repo}.") |
There was a problem hiding this comment.
Couldn't this fail for other reasons? TBH I'm not sure what the goal of this new exception is. Maybe you can clarify the purpose?
There was a problem hiding this comment.
In the case where the user tries to load a local model with the name example_model_name and makes a typo (for example example_model-name, the code still throws the huggingface's RepositoryNotFoundErrorerror, with the following error message:
Repository Not Found for url: https://huggingface.co/api/models/llama3-17b-instruc/revision/main.
Please make sure you specified the correct `repo_id` and `repo_type`.
If you are trying to access a private or gated repo, make sure you are authenticated.for the following line of code:
model, tokenizer = load("llama3-17b-instruc")which is not very informative, as the user is trying to access a local model. Not essential by any means, just something i encountered my first time using the package.
There was a problem hiding this comment.
I see. Maybe it is worth augmenting that error message instead because it's possible they intended to download from HF in which case the message is actually useful.
Something like:
Model Not Found for {model_path}.
Please make sure you specified the local path or Hugging Face repo id correctly.
If you are trying to access a private or gated Hugging Face repo, make sure you are authenticated.
There was a problem hiding this comment.
This looks good, are you going to add the edits or should I?
Added proper error handling to
loadandget_model_pathby adding a dedicated exception class, because when the local path is not right, it still throws the huggingfaceRepositoryNotFoundError, which is not fully informative to the end user, they might have just entered their local path wrong by one character.