Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove husky for now #5127

Merged
merged 1 commit into from
Jun 7, 2024
Merged

chore: remove husky for now #5127

merged 1 commit into from
Jun 7, 2024

Conversation

voxpelli
Copy link
Member

PR Checklist

Overview

@voxpelli voxpelli requested a review from a team March 26, 2024 17:31
@coveralls
Copy link

Coverage Status

coverage: 94.359%. remained the same
when pulling a23bcea on voxpelli/issue5124
into 7ac67f3 on master.

Copy link
Member

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We have a CI. We dont need husky.

@voxpelli
Copy link
Member Author

@JoshuaKGoldberg Did you have any thoughts on this? I'm quite sure you did

@JoshuaKGoldberg
Copy link
Member

I did have thoughts 😄 and they are not in favor 😄 😄 let's discuss in the issue?

@voxpelli
Copy link
Member Author

Right, I'm not used to having split split discussions between issue and PR for small changes like this

@voxpelli voxpelli added the status: in discussion Let's talk about it! label Jun 4, 2024
@voxpelli voxpelli merged commit 6dda9a4 into master Jun 7, 2024
50 of 53 checks passed
@voxpelli voxpelli deleted the voxpelli/issue5124 branch June 7, 2024 10:59
@voxpelli
Copy link
Member Author

voxpelli commented Jun 7, 2024

Discussed in meeting and agreed to remove as the one reason that was found to keep it was to apply automatic formatting prior to commit, but there is no automatic formatting for js-files anyway in this repo, so that reason was not applicable in this case

@voxpelli voxpelli removed the status: in discussion Let's talk about it! label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Repo: Remove husky for now
4 participants