Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post API for embedding model and fix embedding model wrappers #186

Merged
merged 11 commits into from
May 22, 2024
Merged

Add post API for embedding model and fix embedding model wrappers #186

merged 11 commits into from
May 22, 2024

Conversation

ZiTao-Li
Copy link
Collaborator

@ZiTao-Li ZiTao-Li commented Apr 28, 2024 •
edited

Add post API for embedding model and fix embedding model wrappers

Description

  • Add post API for embedding model to provide a default choice for some response format.
  • Fix some bugs (which will not be trigger) in the existing embedding models.

By default, now the return of embedding model wrappers are ModelResponse with list of embeddings.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@ZiTao-Li ZiTao-Li requested review from DavdGao, pan-x-c, qbc2016, FredericW, rayrayraykk and garyzhang99 and removed request for DavdGao and pan-x-c April 28, 2024 07:50
DavdGao
DavdGao reviewed Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz see inline comments and add example configurations in examples/model_configurations/

src/agentscope/models/dashscope_model.py Show resolved Hide resolved
docs/sphinx_doc/en/source/tutorial/203-model.md Outdated Show resolved Hide resolved
@ZiTao-Li
Merge branch 'main' into zitao/embd
35b14aa 
# Conflicts:
#	docs/sphinx_doc/en/source/tutorial/203-model.md
#	docs/sphinx_doc/zh_CN/source/tutorial/203-model.md
@ZiTao-Li
update as comment
8b52c1e
@ZiTao-Li
update documents
489a946
@ZiTao-Li
make ollama consistent
820d170
@ZiTao-Li ZiTao-Li added ready for review bug Something isn't working labels May 9, 2024
DavdGao
DavdGao reviewed May 10, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix the typo, others lgtm

@ZiTao-Li
fix typo in markdown files
e34af7b
@ZiTao-Li
Merge branch 'main' into zitao/embd
70178a1 
# Conflicts:
#	docs/sphinx_doc/en/source/tutorial/203-model.md
@ZiTao-Li
merge
6f89c0a
qbc2016
qbc2016 reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@qbc2016 qbc2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pan-x-c
pan-x-c approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZiTao-Li ZiTao-Li merged commit bbc1657 into modelscope:main May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbc2016 qbc2016 qbc2016 left review comments

@DavdGao DavdGao DavdGao left review comments

@pan-x-c pan-x-c pan-x-c approved these changes

@FredericW FredericW Awaiting requested review from FredericW

@rayrayraykk rayrayraykk Awaiting requested review from rayrayraykk

@garyzhang99 garyzhang99 Awaiting requested review from garyzhang99

Assignees
No one assigned
Labels
bug Something isn't working ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ZiTao-Li @qbc2016 @pan-x-c @DavdGao