Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unittest #304

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Add more unittest #304

wants to merge 28 commits into from

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Apr 24, 2024

  1. setup local actions runner on a GPU machine
  2. use docker-compose to setup a cluster
  3. add more unit tests
    • single process
    • multi process
    • multi process with GPU
    • ray with CPU
    • ray with GPU

@pan-x-c pan-x-c added the enhancement New feature or request label Apr 24, 2024
@pan-x-c pan-x-c self-assigned this Apr 24, 2024
@pan-x-c pan-x-c changed the title [WIP] Add more unittest Add more unittest May 7, 2024
Copy link

This PR is marked as stale because there has been no activity for 21 days. Remove stale label or add new comments or this PR will be closed in 3 day.

capabilities: [gpu]

ray-worker:
image: data-juicer-unittest:0.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we may change it into data-juicer-unittest:latest and maintain a latest image

from data_juicer.utils.registry import Registry

SKIPPED_TESTS = Registry('SkippedTests')


def TEST_TAG(*tags):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two type of tags, while the PR's description mentioned 5 types of test scenarios. So what is the mapping relationship?

single process
multi process
multi process with GPU
ray with CPU
ray with GPU

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, there is no distinction between CPU and GPU testing, and the corresponding configuration will be added in the future when needed.


jobs:
unittest-single:
runs-on: [self-hosted, linux]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By now, does our self-hosted machine satisfy the requirements from security colleagues?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

@github-actions github-actions bot removed the stale-pr label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants