[mojo-stdlib] Add variadic initialiser, __iter__ and __contains__ to InlineList #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Variadic Initialisation - Iteration - Contains Signed-off-by: Chris Sutton <christopher.sutton12@gmail.com>
Signed-off-by: Chris Sutton <christopher.sutton12@gmail.com>
Signed-off-by: Chris Sutton <christopher.sutton12@gmail.com>
Signed-off-by: Chris Sutton <christopher.sutton12@gmail.com>
ChristopherLR
force-pushed
the
update-inline-list
branch
from
d2267df
to
1792993
Compare
laszlokindrat
approved these changes
May 17, 2024
laszlokindrat
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
soraros
reviewed
May 17, 2024
| _type_is_eq[ElementType, C](), "value type is not self.ElementType" | ||
| ]() | ||
| for i in self: | ||
| if value == rebind[C](i[]): |
There was a problem hiding this comment.
@laszlokindrat rebind doesn't work for mem types.
There was a problem hiding this comment.
@soraros, right, I missed this, can you put up a patch to fix this? Or to document this limitation?
modularbot
pushed a commit
that referenced
this pull request
May 18, 2024
…tains__ to InlineList (#40189) [External] [mojo-stdlib] Add variadic initialiser, __iter__ and __contains__ to InlineList This PR adds some features to InlineList ( related issue #2658 ) *Variadic initialiser* ```mojo var x = InlineList[Int](1,2,3) ``` *iter* ```mojo var x = InlineList[Int](1,2,3) for i in x: print(i) ``` *contains* ```mojo var x = InlineList[Int](1,2,3) if 3 in x: print("ok") ``` Co-authored-by: Chris <32541739+ChristopherLR@users.noreply.github.com> Closes #2703 MODULAR_ORIG_COMMIT_REV_ID: 6a9eb7b41905e62f8db0855159fd851b7ffb6174
|
Landed in d5b7381! Thank you for your contribution 🎉 |
msaelices
pushed a commit
to msaelices/mojo
that referenced
this pull request
May 18, 2024
…tains__ to InlineList (#40189) [External] [mojo-stdlib] Add variadic initialiser, __iter__ and __contains__ to InlineList This PR adds some features to InlineList ( related issue modularml#2658 ) *Variadic initialiser* ```mojo var x = InlineList[Int](1,2,3) ``` *iter* ```mojo var x = InlineList[Int](1,2,3) for i in x: print(i) ``` *contains* ```mojo var x = InlineList[Int](1,2,3) if 3 in x: print("ok") ``` Co-authored-by: Chris <32541739+ChristopherLR@users.noreply.github.com> Closes modularml#2703 MODULAR_ORIG_COMMIT_REV_ID: 6a9eb7b41905e62f8db0855159fd851b7ffb6174
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
…tains__ to InlineList (#40189) [External] [mojo-stdlib] Add variadic initialiser, __iter__ and __contains__ to InlineList This PR adds some features to InlineList ( related issue modularml#2658 ) *Variadic initialiser* ```mojo var x = InlineList[Int](1,2,3) ``` *iter* ```mojo var x = InlineList[Int](1,2,3) for i in x: print(i) ``` *contains* ```mojo var x = InlineList[Int](1,2,3) if 3 in x: print("ok") ``` Co-authored-by: Chris <32541739+ChristopherLR@users.noreply.github.com> Closes modularml#2703 MODULAR_ORIG_COMMIT_REV_ID: 6a9eb7b41905e62f8db0855159fd851b7ffb6174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some features to InlineList ( related issue #2658 )
Variadic initialiser
iter
contains