[stdlib][NFC] Improve tests for utils.numerics #2727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
…_inf Signed-off-by: Manuel Saelices <msaelices@gmail.com>
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
laszlokindrat
changed the title
|
Thanks for the patch! Does this fully address #2680? I.e. is there any other function in |
laszlokindrat
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
|
Landed in 18f1eaa! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
May 18, 2024
[External] [stdlib][NFC] Improve tests for utils.numerics ## Changes - [X] Alpha order on `test_simd.mojo` to easier overview - [X] Tests for `get_accum_type()`, `mex_or_inf()`, `min_finite()`, `min_or_neg_inf()`, `nextafter()` and `neg_inf()` ## Ref See #2680 Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes #2727 MODULAR_ORIG_COMMIT_REV_ID: cc66c1163ae663010cac482518b57fbedb0aa636
msaelices
added a commit
to msaelices/mojo
that referenced
this pull request
May 18, 2024
[External] [stdlib][NFC] Improve tests for utils.numerics ## Changes - [X] Alpha order on `test_simd.mojo` to easier overview - [X] Tests for `get_accum_type()`, `mex_or_inf()`, `min_finite()`, `min_or_neg_inf()`, `nextafter()` and `neg_inf()` ## Ref See modularml#2680 Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes modularml#2727 MODULAR_ORIG_COMMIT_REV_ID: cc66c1163ae663010cac482518b57fbedb0aa636
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
[External] [stdlib][NFC] Improve tests for utils.numerics ## Changes - [X] Alpha order on `test_simd.mojo` to easier overview - [X] Tests for `get_accum_type()`, `mex_or_inf()`, `min_finite()`, `min_or_neg_inf()`, `nextafter()` and `neg_inf()` ## Ref See modularml#2680 Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes modularml#2727 MODULAR_ORIG_COMMIT_REV_ID: cc66c1163ae663010cac482518b57fbedb0aa636
modularbot
pushed a commit
that referenced
this pull request
Jun 7, 2024
[External] [stdlib][NFC] Improve tests for utils.numerics ## Changes - [X] Alpha order on `test_simd.mojo` to easier overview - [X] Tests for `get_accum_type()`, `mex_or_inf()`, `min_finite()`, `min_or_neg_inf()`, `nextafter()` and `neg_inf()` ## Ref See #2680 Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes #2727 MODULAR_ORIG_COMMIT_REV_ID: cc66c1163ae663010cac482518b57fbedb0aa636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
test_simd.mojoto easier overviewget_accum_type(),mex_or_inf(),min_finite(),min_or_neg_inf(),nextafter()andneg_inf()Ref
See #2680