Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rye as a package manager. #46

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

manisha841
Copy link
Contributor

@manisha841 manisha841 commented Apr 22, 2024

  • Added rye config

Use the following commands to set up rye in your system.

@manisha841 manisha841 changed the title Add poetry as a package manager. Add rye as a package manager. Apr 24, 2024
@manisha841 manisha841 marked this pull request as ready for review May 4, 2024 14:43
Copy link
Contributor

@horrormyth horrormyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment otherwise great stuff ⛩️ 💪

CONTRIBUTION.md Outdated
3. Add Rye on your system if it is not installed already. [Source](https://rye-up.com/guide/installation/)
4. Install all the dependencies using `rye sync`.
5. Install pre-commit hook using `rye run pre-commit install`
6. Run `rye add package_name` (if you wish to add any packages as per your requirements.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be good to hint that sync is necessary, as add does not provide the packages to the working env

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

version = "0.1.0"
description = "Add your description here"
authors = [
{ name = "Manisha Bhandari", email = "manishabhandari841@gmail.com" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Probably not needed, commit has all the necessary information

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these informations are necessary as they serve as the main configuration of the project, but open for discussions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the author details

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project author should be moest-np.

@sapradhan
Copy link
Collaborator

I see a lot of effort being put into this, greatly appreciate it.
I had not heard about rye before this, not much into python ecosystem, so a few questions -

  • How wide is the adoption of rye as a package manager?
  • skimming through the documentation, rye does appear to be better than pip, in par with modern package managers. But I believe it does not ship with python installation, so for a newbie like me, it would be one more thing to install and learn. For a project of this size would it add value to make this switch?

@horrormyth
Copy link
Contributor

horrormyth commented May 5, 2024

I see a lot of effort being put into this, greatly appreciate it. I had not heard about rye before this, not much into python ecosystem, so a few questions -

  • How wide is the adoption of rye as a package manager?
  • skimming through the documentation, rye does appear to be better than pip, in par with modern package managers. But I believe it does not ship with python installation, so for a newbie like me, it would be one more thing to install and learn. For a project of this size would it add value to make this switch?

Rye manages the package, including the virtual environments and Python one needs, so I think it would be much easier to use Rye as a one-stop solution, as one won't need to worry about Python's virtual environments madness.

For a project of this size would it add value to make this switch?

I agree that for the size of this project, it might be a bit cumbersome, but if we think from the dev's perspective, it might be better off with this one with the main rationale being separation and management of the packages, depending on the dev, test, and ... environment and managing the virtualenvs. After all, we should always opt for the betterment direction. Since we are already using the Streamlint app, I am sure there will be many more packages coming in the future. It's always good to have one less tech debt from the get-go.

Copy link

@imkaka imkaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉👏

version = "0.1.0"
description = "Add your description here"
authors = [
{ name = "Manisha Bhandari", email = "manishabhandari841@gmail.com" }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project author should be moest-np.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants