input: prioritize builtin bindings matching longer key sequences #14157
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidocella
force-pushed
the
prioritize-longer-sequences
branch
from
a53377e
to
2efac97
Compare
guidocella
changed the title
|
Download the artifacts for this pull request: |
kasper93
reviewed
May 17, 2024
This fixes 2 different bugs:
- mp.add_key_binding('c', ...) taking priority over the builtin g-c
binding.
This follows up 994a08f which fixed this within the same input
section. This fixes it across different input sections.
- mp.add_key_binding('g-c', ...) not taking priority over a c binding
defined in input.conf.
This happened because is_builtin of bindings added with
mp.add_key_binding is true though they're not actually builtin.
guidocella
force-pushed
the
prioritize-longer-sequences
branch
from
2efac97
to
2bf78d2
Compare
|
|
|
Why wouldn't it? |
|
Because I have to put |
|
This is the documented and expected behavior: "If a or a-b or b are already bound, this will run the first command that matches, and the multi-key command will never be called. Intermediate keys can be remapped to ignore in order to avoid this issue. The maximum number of (non-modifier) keys for combinations is currently 4." |
|
Fair, I guess. |
kasper93
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 different bugs:
This follows up 994a08f which fixed this within the same input section. This fixes it across different input sections.
This happened because is_builtin of bindings added with mp.add_key_binding is true though they're not actually builtin.