DataTextureLoader: Simplify default value for texData. #28366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
May 13, 2024
| magFilter = LinearFilter, | ||
| minFilter = LinearFilter, | ||
| anisotropy = 1, | ||
| } = texData; |
There was a problem hiding this comment.
Apparently I have to get used to this kind of coding style^^. It is still not 100% intuitive to me...
There was a problem hiding this comment.
TBH, this one has a learning cost, but if you use it for a while, you maybe like this grammar candy. After all, less code is being written. There should be no side effects.
There was a problem hiding this comment.
I don't think it improved readability honestly...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #XXXX
Description
As the title says.