Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TelegramTrigger Node): Replace allowedUpdates value for '*' option with full range of possible update types #9321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seniorsolt
Copy link

@seniorsolt seniorsolt commented May 7, 2024

Current value of allowedUpdates for '*' option is set to an empty array, which enables "all update types except chat_member, message_reaction, and message_reaction_count (default)". More details can be found in the Telegram Bot API documentation

It causes not receiving updates about new channel subscriber for example.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

value for '*' option with full range of possible update types
@CLAassistant
Copy link

CLAassistant commented May 7, 2024

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels May 7, 2024
@Joffcom
Copy link
Member

Joffcom commented May 20, 2024

Hey @seniorsolt,

Thanks for the PR, I have been thinking about this one and I believe that this has some potential to cause some issues if you are not expecting those 3 extra fields. This could be better as a light version with an option to use the default Telegram list if those 3 options are not needed, I guess there is a reason why they are not included in the first place.

@seniorsolt
Copy link
Author

seniorsolt commented May 21, 2024

Hello, @Joffcom,

Could you please clarify what kind of potential issues you are referring to? Are you talking about breaking old workflows after updating due to unexpected update types? Should I create a new request with a new option that includes a full range of possible update types instead of replacing '*' option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants