feat(lsp): add the end location information of lsp to quickfix item #28724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sample usage of nvim-bqf, which utilizes the Before this PR: After:
|
|
The information will also be shown in the default quickfix window |
ofseed
force-pushed
the
complete-quickfix-item
branch
from
d14901f
to
a4a5729
Compare
ofseed
force-pushed
the
complete-quickfix-item
branch
from
a4a5729
to
b2fafbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's the support of
end_lnumandend_colfor quickfix already, which was originally designed to support LSP locations, see vim/vim#8393, and it has already been patched to nvim.After making these distinctions, this code looks ugly. I'm not sure if I need to refactor