Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add getConnections method for retrieving node connections #364

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

a876691666
Copy link
Contributor

@a876691666 a876691666 commented Jan 16, 2024

This commit adds the retrieveNodeConnections method, which allows retrieving the connections associated with a given node. This functionality is necessary for retrieving and managing the connections of a node, enabling better analysis and manipulation of the node's relationships.

@a876691666
Copy link
Contributor Author

a876691666 commented Jan 16, 2024

case:

props.node.graph?.retrieveNodeConnections(props.intf).forEach((connection) => {
  props.node.graph?.removeConnection(connection);
});

@newcat
Copy link
Owner

newcat commented Jan 24, 2024

The method takes a node interface, not a node as the parameter. So I am a little bit confused - do you want to retrieve all connections for a node? In that case, the logic needs to be changed. If you want to retrieve all connections for a given node interface, then the method and parameter names should be changed.

@a876691666
Copy link
Contributor Author

It seems so, there's a naming issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants