-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Microsoft Entra ID typos #10834
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@mariusch is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree on the import naming here. MicrosoftEntraID
is better for the documentations. 😊
Hey thanks for the camelCase signIn related changes. Regarding the Entra import, that provider is a default export so you should be able to name it whatever you want. Can you double check that leaving it as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm, importing as Entra
does still work as expected. However, MicrosoftEntraId
is technically more correct so I'll take this PR as-is.
Thanks! 🙏
☕️ Reasoning
Ran into some minor issues when upgrading to version 5. The name of the provider should be MicrosoftEntraID. NextAuth exports signIn and signOut in camelCase.
🧢 Checklist
🎫 Affected issues
📌 Resources