Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Microsoft Entra ID typos #10834

Merged
merged 5 commits into from
May 17, 2024

Conversation

mariusch
Copy link
Contributor

@mariusch mariusch commented May 6, 2024

☕️ Reasoning

Ran into some minor issues when upgrading to version 5. The name of the provider should be MicrosoftEntraID. NextAuth exports signIn and signOut in camelCase.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) May 17, 2024 11:32am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 11:32am

Copy link

vercel bot commented May 6, 2024

@mariusch is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@kongebra kongebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on the import naming here. MicrosoftEntraID is better for the documentations. 😊

@ndom91
Copy link
Member

ndom91 commented May 16, 2024

Hey thanks for the camelCase signIn related changes.

Regarding the Entra import, that provider is a default export so you should be able to name it whatever you want.

Can you double check that leaving it as Entra really doesn't work for you? 🤔

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm, importing as Entra does still work as expected. However, MicrosoftEntraId is technically more correct so I'll take this PR as-is.

Thanks! 🙏

@ndom91 ndom91 merged commit d53d47c into nextauthjs:main May 17, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants