Dismiss notification of successful downloads

[ZetaTom]

Sometimes download notifications could be stuck at 100% and not be dismissed automatically. In a previous pull request these notifications were made dismissible by the end user as a workaround. This pull request aims to minimise the edge cases where notifications become stuck.

Test Procedure

1. Set breakpoint on FileActivity.java:524 and FileActivity.java:542
2. Start app in debug mode
3. Open overflow menu of any file
4. Select Download
5. Wait until the breakpoint is hit
6. Close the app and continue running
7. Wait for some amount of time
8. re-open the app

Without this patch the Downloading... notification is displayed but not automatically dismissed. IT should now be dismissed automatically.

---

• Tests written, or not not needed

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	72	72
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	64	64
Correctness	69	69
Dodgy code	347	347
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	6	6
Performance	57	57
Security	19	19
Total	572	572

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13013.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[alperozturk96]

@AndyScherzinger "task-list-completed" phase still In progress. How can we re-trigger it? “/rebase” ?

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!