Create individual workers for every Autoupload Folder #13015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasMayerDev
changed the title
5 tasks
JonasMayerDev
force-pushed
the
remove-foreground-worker-for-auto-upload
branch
3 times, most recently
from
d011ec9
to
49103a7
Compare
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
JonasMayerDev
force-pushed
the
remove-foreground-worker-for-auto-upload
branch
from
bbc8743
to
d91b652
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13015.apk |
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13015-Screenshot-blue-Light-18-26 |
alperozturk96
approved these changes
Jun 3, 2024
delete-merged-branch
bot
deleted the
remove-foreground-worker-for-auto-upload
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally gets rid of the foreground worker and the corresponding notification by lowering the chance the worker gets killed.
Internally, the app now starts a new worker for every auto upload folder instead of one worker for all folders.
Advantages are:
The best way to test is using logcat and filtering for "File sync" since all important log messages start with that term. Like this, you should be able to observe the behavior of the background worker without messing with it. If you want to check something specific, use the debugger, but be aware that that changes behavior (like execution speed).