Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: exit on unsupported host OS for Android #52882

Merged
merged 1 commit into from
May 25, 2024
Merged

build: exit on unsupported host OS for Android #52882

merged 1 commit into from
May 25, 2024

Conversation

VoltrexKeyva
Copy link
Member

The Android configure script throws an unhelpful error message telling the user that toolchain_path is not defined when the script is run on an unsupported host OS, exit with a more helpful message instead while listing the supported host OSes.

@VoltrexKeyva VoltrexKeyva added build Issues and PRs related to build files or the CI. android Issues and PRs related to the android platform. labels May 8, 2024
@lpinca
Copy link
Member

lpinca commented May 11, 2024

Wouldn't it be better to fix it here

node/android_configure.py

Lines 13 to 15 in cbd6ddb

if platform.system() == "Windows":
print("android-configure is not supported on Windows yet.")
sys.exit(1)

@VoltrexKeyva
build: exit on unsupported host OS for Android
9bfa94f 
The Android configure script throws an unhelpful error message telling
the user that `toolchain_path` is not defined when the script is run on
an unsupported host OS, exit with a more helpful message instead while
listing the supported host OSes.
@VoltrexKeyva
Copy link
Member Author

I assume this doesn't need a Jenkins CI right?

@VoltrexKeyva VoltrexKeyva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0cbbab9 into nodejs:main May 25, 2024
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0cbbab9

@VoltrexKeyva VoltrexKeyva deleted the throw-unsup-os branch May 25, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
android Issues and PRs related to the android platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@VoltrexKeyva @lpinca @nodejs-github-bot @jasnell