Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv #52905

Merged
merged 2 commits into from
May 23, 2024
Merged

src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv #52905

merged 2 commits into from
May 23, 2024

Conversation

RafaelGSS
Copy link
Member

Fixes: #51227

Currently, I'm throwing kBootstrapError, but I'm almost sure this is not the appropriate error. In this case, should I create a new error?

Technically, this is a fix for kDisableNodeOptionsEnv, but it can be considered a breaking change for the ones relying on the current behavior (which is unlikely).

@RafaelGSS RafaelGSS requested a review from joyeecheung May 8, 2024 17:55
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 8, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented May 8, 2024 •
edited

IMO if it's a breaking change it should be semver-minor or notable-change

(But as a triage member, this isn't my decision, nor my place)

@RedYetiDev RedYetiDev added the repl Issues and PRs related to the REPL subsystem. label May 8, 2024
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2024
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/9008046172

@RafaelGSS RafaelGSS removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label May 9, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59055/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59062/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59085/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59173/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59198/

Trott
Trott approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opinion from me on semver for this, but the code change LGTM.

Trott
Trott reviewed May 14, 2024
View reviewed changes
doc/api/cli.md
Comment on lines +2783 to +2853
changes:
- version:
- REPLACEME
pr-url: https://github.com/nodejs/node/pull/52905
description:
Remove the possibility to use this env var with
kDisableNodeOptionsEnv for embedders.

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

@Trott
Copy link
Member

Trott commented May 14, 2024

No opinion from me on semver for this, but the code change LGTM.

Actually, with a little more thought, I think this is semver patch, so I agree with @RafaelGSS. But I'll defer to Releasers who think otherwise or collaborators more knowledgable about how these features are used.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2024
@RedYetiDev
Copy link
Member

No opinion from me on semver for this, but the code change LGTM.

Actually, with a little more thought, I think this is semver patch

Whatever you say I'm happy with, I'm not a collaborator, so I really don't have much of an opinion (and experience) to really weigh in

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59247/

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59267/

@RafaelGSS RafaelGSS added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels May 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59322/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59336/

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59337/

@richardlau
Copy link
Member

I'm getting

14:08:05 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/embedtest: error while loading shared libraries: libcrypto.so.1.1: cannot open shared object file: No such file or directory

I don't see why my changes would cause this. Any idea? @nodejs/build

In your new test you're overwriting the environment and losing the environment variables required to spawn node when dynamically linked against dependencies (e.g. OpenSSL). On Linux that would LD_LIBRARY_PATH but could be LIBPATH (AIX) or DYLD_LIBRARY_PATH (macOS). The usual approach in tests is to extend the env rather than replace it.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59352/

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 23, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/52905
✔  Done loading data for nodejs/node/pull/52905
----------------------------------- PR info ------------------------------------
Title      src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv (#52905)
Author     Rafael Gonzaga  (@RafaelGSS)
Branch     RafaelGSS:disable-external-module -> nodejs:main
Labels     c++, repl, author ready, needs-ci, commit-queue-squash
Commits    2
 - src: fix external module env and kDisableNodeOptionsEnv
 - fixup! src: fix external module env and kDisableNodeOptionsEnv
Committers 1
 - RafaelGSS 
PR-URL: https://github.com/nodejs/node/pull/52905
Fixes: https://github.com/nodejs/node/issues/51227
Reviewed-By: Rich Trott 
Reviewed-By: Joyee Cheung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52905
Fixes: https://github.com/nodejs/node/issues/51227
Reviewed-By: Rich Trott 
Reviewed-By: Joyee Cheung 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - fixup! src: fix external module env and kDisableNodeOptionsEnv
   ℹ  This PR was created on Wed, 08 May 2024 17:55:32 GMT
   ✔  Approvals: 2
   ✔  - Rich Trott (@Trott): https://github.com/nodejs/node/pull/52905#pullrequestreview-2056494543
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/52905#pullrequestreview-2069699196
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-05-22T14:10:03Z: https://ci.nodejs.org/job/node-test-pull-request/59352/
- Querying data for job/node-test-pull-request/59352/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9200620708

@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 23, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2024
@nodejs-github-bot nodejs-github-bot merged commit b9ad94b into nodejs:main May 23, 2024
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b9ad94b

StefanStojanovic added a commit to JaneaSystems/node that referenced this pull request May 27, 2024
@StefanStojanovic
test: fix Windows native test suites
169b0f8 
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: nodejs#52905
Refs: nodejs#52646
@StefanStojanovic StefanStojanovic mentioned this pull request May 27, 2024
Merged
StefanStojanovic added a commit to JaneaSystems/node that referenced this pull request May 27, 2024
@StefanStojanovic
test: fix Windows native test suites
6735452 
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: nodejs#52905
Refs: nodejs#52646
nodejs-github-bot pushed a commit that referenced this pull request May 27, 2024
@StefanStojanovic
test: fix Windows native test suites
8e9686d 
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: #52905
Refs: #52646
PR-URL: #53173
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The kDisableNodeOptionsEnv option can be work around by using NODE_REPL_EXTERNAL_MODULE env
7 participants
@RafaelGSS @nodejs-github-bot @RedYetiDev @Trott @richardlau @joyeecheung @juanarbol