feat(stdlib)!: eddsa function using turbofish #5050

vezenovm · 2024-05-17T21:51:23Z

Description

Problem*

Resolves #4514

Summary*

This updates eddsa_verify_with_hasher to have the following signature now that we support the turbofish operator:

pub fn eddsa_verify_with_hasher<H>(
    pub_key_x: Field,
    pub_key_y: Field,
    signature_s: Field,
    signature_r8_x: Field,
    signature_r8_y: Field,
    message: Field
) -> bool 
where H: Hasher + Default {
  [function body ...]
}

This re-work was only possible with further bug fixes from #5049 and #5041. The original turbofish PR can be found here (#3542).

Additional Context

This PR can most likely be merged into its parent #5049 but I just made this separate PR to separate the bug fix and the stdlib library breaking change.

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

* master: (120 commits) feat: allow passing custom foreign call handlers when creating proofs in NoirJS (#3764) fix: add missing assertion to test (#3765) chore: re-export the items needed for the lsp from the fm crate instead of importing codespan_reporting (#3757) chore: remove special casing for `pedersen_hash` black box function (#3744) chore: remove extraneous dbg statement (#3761) chore: fix un-needed fully qualified path (#3755) feat: aztec-packages (#3754) feat: allow underscores in integer literals (#3746) fix: deserialize odd length hex literals (#3747) feat: optimize out unnecessary truncation instructions (#3717) chore: use `tsx` instead of `ts-node` for `noir_js` (#3750) chore(ci): fail `tests-end` job if any dependants failed (#3737) chore: allow common ascii punctuation in attributes (#3733) chore: fix broken onboarding link in README (#3732) feat: Dockerfile to test cargo and JS packages (#3684) feat(lsp): add goto definition for locals (#3705) feat: docs landing page with a playground (#3667) fix: `try_unify` no longer binds types on failure (#3697) fix: parse negative integer literals (#3698) fix: unsigned integers cannot be negated (#3688) ...

… be better as a separate PR

…e self

vezenovm · 2024-05-20T23:00:35Z

I'm inclined to just rename this to eddsa_verify at this point.

Renamed it

…ze-fix

chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081) chore: update `nargo info` table to remove circuit size column feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080) fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941) chore(experimental): Elaborate globals (noir-lang/noir#5069) chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066) feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058) chore: use `bbup` to install `bb` (noir-lang/noir#5073) feat: Sync from aztec-packages (noir-lang/noir#5070) chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071) feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050) fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049)

…r-lang/noir#5097) chore(docs): Link to evmdiff for supported EVM chains (noir-lang/noir#5107) chore: Avoid creating witness for simple multiplications (noir-lang/noir#5100) feat: Add intrinsic to get if running inside an unconstrained context (noir-lang/noir#5098) chore: Move turbofish changes to the elaborator (noir-lang/noir#5094) fix: Apply self type from generic trait constraint before instantiating identifiers (noir-lang/noir#5087) chore: reactivate gates report (noir-lang/noir#5084) chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081) chore: update `nargo info` table to remove circuit size column feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080) fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941) chore(experimental): Elaborate globals (noir-lang/noir#5069) chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066) feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058) chore: use `bbup` to install `bb` (noir-lang/noir#5073) feat: Sync from aztec-packages (noir-lang/noir#5070) chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071) feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050) fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049)

…5097) chore(docs): Link to evmdiff for supported EVM chains (noir-lang/noir#5107) chore: Avoid creating witness for simple multiplications (noir-lang/noir#5100) feat: Add intrinsic to get if running inside an unconstrained context (noir-lang/noir#5098) chore: Move turbofish changes to the elaborator (noir-lang/noir#5094) fix: Apply self type from generic trait constraint before instantiating identifiers (noir-lang/noir#5087) chore: reactivate gates report (noir-lang/noir#5084) chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081) chore: update `nargo info` table to remove circuit size column feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080) fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941) chore(experimental): Elaborate globals (noir-lang/noir#5069) chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066) feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058) chore: use `bbup` to install `bb` (noir-lang/noir#5073) feat: Sync from aztec-packages (noir-lang/noir#5070) chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071) feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050) fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: Consider block parameters in variable liveness (noir-lang/noir#5097) chore(docs): Link to evmdiff for supported EVM chains (noir-lang/noir#5107) chore: Avoid creating witness for simple multiplications (noir-lang/noir#5100) feat: Add intrinsic to get if running inside an unconstrained context (noir-lang/noir#5098) chore: Move turbofish changes to the elaborator (noir-lang/noir#5094) fix: Apply self type from generic trait constraint before instantiating identifiers (noir-lang/noir#5087) chore: reactivate gates report (noir-lang/noir#5084) chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081) chore: update `nargo info` table to remove circuit size column feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080) fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941) chore(experimental): Elaborate globals (noir-lang/noir#5069) chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066) feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058) chore: use `bbup` to install `bb` (noir-lang/noir#5073) feat: Sync from aztec-packages (noir-lang/noir#5070) chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071) feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050) fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: sirasistant <sirasistant@gmail.com>

…rait methods (#5108) # Description ## Problem\* Resolves the single "Duplicate definitions of <generic> found" error. ## Summary\* Since `resolve_trait_function` already calls `add_generics` indirectly via `define_function_meta`, we were adding generics on trait methods twice before. I've removed the first of the two to fix this. ## Additional Context After this the only errors that remain are the 5 on these lines of the stdlib: https://github.com/noir-lang/noir/blob/master/noir_stdlib/src/eddsa.nr#L49-L53. I believe these are the result of something from the turbofish changes being missed (likely #5041) since they were recently modified from #5050. ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.

jfecher and others added 30 commits November 21, 2023 15:26

Add turbofish operator; add stack overflow crash

04ea5d0

Fix parsing error

3a95229

Add test

427cb95

Add compiler error for incorrect generic count

3ab58b8

Edit example to have a more problematic case

8fc453a

resolved merge conflicts

b9673b2

fixup remaining fmt stuff

b289b87

cleanup

6127baf

cargo fmt

9ebb3b5

working initial turbofish tests

c652541

cargo fmt

9660360

nargo fmt

4cee817

clippy

e89cde2

fmt

a2da705

nargo fmt

da23029

fix nargo fmt for turbofish on method calls

da26bc3

clippy

77dfc19

initial work to get calling trait methods working, decided this would…

0e5a579

… be better as a separate PR

working turbofish with implicit generics now

c17e834

separate out function and implicit generic counts

8f2be2e

merge conflicts w/ jf/turbofish and working trait methods with mutabl…

405683e

…e self

cleanup

5ad8fb4

Merge branch 'master' into jf/turbofish

e7000d7

merge conflicts w/ parent jf/turbofish

3cbba0b

cargo fmt

cc135e7

cleanup

a0090c1

nargo fmt

954aba7

add todo comments

1e22003

specify type annotation for hasher

44a4aee

vezenovm added 2 commits May 20, 2024 22:58

Merge branch 'mv/turbofish-monomorphize-fix' into mv/eddsa-turbofish

ca31866

rename to eddsa_verify

bacb36a

vezenovm added 9 commits May 21, 2024 13:20

move where implciit_generic_count is computed

bf07ee8

switch to single loop in instantiate_with

a9cb6c4

rename to turbofish_generics

daf151b

Merge branch 'master' into jf/turbofish

0d887de

Merge branch 'jf/turbofish' into mv/trait-method-reference

8d93a66

Merge branch 'master' into jf/turbofish

a44782b

Merge branch 'jf/turbofish' into mv/trait-method-reference

d174e13

Merge branch 'mv/trait-method-reference' into mv/turbofish-monomorphi…

29bb0ae

…ze-fix

Merge branch 'mv/turbofish-monomorphize-fix' into mv/eddsa-turbofish

569544c

Base automatically changed from mv/turbofish-monomorphize-fix to master May 21, 2024 19:27

vezenovm added 2 commits May 21, 2024 19:34

merge w/ master

ea7cc2f

delete duplicated function-generic_count

0123ac8

vezenovm enabled auto-merge May 21, 2024 19:37

vezenovm added this pull request to the merge queue May 21, 2024

Merged via the queue into master with commit 7936262 May 21, 2024
41 checks passed

vezenovm deleted the mv/eddsa-turbofish branch May 21, 2024 19:56

kevaundray mentioned this pull request May 21, 2024

chore: Release Noir(0.31.0) #5061

Closed

AztecBot mentioned this pull request May 23, 2024

feat: Sync from noir AztecProtocol/aztec-packages#6631

Merged

jfecher mentioned this pull request May 24, 2024

fix(experimental elaborator): Avoid calling add_generics twice on trait methods #5108

Merged

5 tasks

AztecBot mentioned this pull request May 27, 2024

chore(master): Release 0.42.0 AztecProtocol/aztec-packages#6572

Merged

noirwhal mentioned this pull request Jun 4, 2024

chore: Release Noir(0.31.0) #5166

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(stdlib)!: eddsa function using turbofish #5050

feat(stdlib)!: eddsa function using turbofish #5050

vezenovm commented May 17, 2024 •

edited

vezenovm commented May 20, 2024

feat(stdlib)!: eddsa function using turbofish #5050

feat(stdlib)!: eddsa function using turbofish #5050

Conversation

vezenovm commented May 17, 2024 • edited

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

vezenovm commented May 20, 2024

vezenovm commented May 17, 2024 •

edited