Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow eslint-plugin-import to Resolve TypeScript Files #44

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Allow eslint-plugin-import to Resolve TypeScript Files #44

wants to merge 6 commits into from
+366 −9

Conversation

DonIsaac
Copy link
Contributor

What This PR Does

  • Allow JS files to use CommonJS require()
  • Add eslint-import-resolver-typescript so that eslint-plugin-import can resolve TypeScript imports
  • Add typescript as a dev dependency
  • Add a npm run typecheck script to run tsc on source code without emitting compiled output

@bmschmidt
Copy link
Collaborator

Is require() desirable? As someone who avoided javascript in the bad old days, I have an aversion.

@DonIsaac
Copy link
Contributor Author

No, but it's needed in config files. I can modify the rules to only apply to those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DonIsaac @bmschmidt