Implement FreeBSD support #2007
Conversation
|
Is this still a draft? I'm looking to clear up our PR issue list and so would appreciate it if you either publish the final PR or keep the drafts in your own fork until they are ready for inclusion. Thank you! If the purpose is just feedback, then I'm not sure what you get from commenting out the maintenance tool. |
| @@ -67,6 +67,8 @@ bool LLM::checkForUpdates() const | |||
| QString tool("maintenancetool.exe"); | |||
| #elif defined(Q_OS_DARWIN) | |||
| QString tool("../../../maintenancetool.app/Contents/MacOS/maintenancetool"); | |||
| #elif defined(Q_OS_FREEBSD) | |||
There was a problem hiding this comment.
Yeah, this is not necessary. You don't have an actual installer built from Qt installer framework with FREEBSD so this does nothing.
| @@ -41,6 +43,10 @@ static long long getSystemTotalRAMInBytes() | |||
| memoryStatus.dwLength = sizeof(memoryStatus); | |||
| GlobalMemoryStatusEx(&memoryStatus); | |||
| totalRAM = memoryStatus.ullTotalPhys; | |||
| #elif defined(__FreeBSD__) | |||
| int mib[2] = {CTL_HW, HW_PHYSMEM}; | |||
There was a problem hiding this comment.
This is fine with me, but I have no way of testing it. If you verify this works for you I'm happy to add it, but you have to remove the draft, verify it works, and remove the maintenance tool change.
|
The two lines about maintenancetool were added just to fix a compile error. I don't know if this PR should be merged... I verified it, but it doesn't seem needed because the main function (chat) is not working in FreeBSD. |
I told rxkes to open a draft PR so I could see their progress on FreeBSD support (#1986). It seems like the dlopen is not working as expected on FreeBSD and/or the backend is not getting built correctly, and I haven't had time to look into this - but I do have a FreeBSD VM handy. |
Describe your changes
Some minor additions.