Add output token control to CLI interface #2225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebtenzzre
reviewed
Apr 17, 2024
gpt4all-bindings/cli/app.py
Outdated
Comment on lines
17
to
30
| # Set default values | ||
| n_predict_default = 200 | ||
| n_predict = n_predict_default | ||
|
|
||
| def getUserTokens(n_tokens_start): | ||
| print(f"Tokens = {n_tokens_start}; ") | ||
| t_input = input("New max tokens? ") | ||
| if t_input.isdigit(): | ||
| t_input=int(t_input) | ||
| if t_input > 0: | ||
| print(f"New tokens {t_input}") | ||
| global n_predict | ||
| n_predict=t_input | ||
| else: print("Invalid entry") |
There was a problem hiding this comment.
- n_predict_default is only used once, remove it
- use four spaces for indentation, not tabs
else:should be on its own line- use spaces around
= - the
;at the end of the first line doesn't make sense, did you wantend=""as well? - check for ValueError from int(), do not use isdigit
- you need to sign off on your commit to accept the DCO
5 tasks
Signed-off-by: Jonathan <compilebunny@qgenuity.com>
Signed-off-by: Jonathan <compilebunny@qgenuity.com>
compilebunny
force-pushed
the
cli_updates
branch
from
be00ed7
to
63831fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updated the text interface (CLI) to let the user set the number of output tokens via the command "/token". If this is accepted, I will probably add LocalDocs/Langchain support next time,
Issue ticket number and link
Checklist before requesting a review
Demo
Steps to Reproduce
Notes
This is a simple update.