fix(web): fixed the flaky failing e2e tests after the changes we introduced with the async launch darkly #5575
Conversation
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| cy.getByTestId('email').type('test-user-1@example.com'); | ||
| cy.getByTestId('password').type('123qwe!@#'); | ||
| cy.getByTestId('submit-btn').click(); | ||
|
|
||
| cy.waitLoadFeatureFlags(); | ||
|
|
||
| cy.waitForNetworkIdle(500); |
There was a problem hiding this comment.
Seems like there were some race conditions between the network and logic to mock the launch darkly requests, but not 100% sure.
| cy.visit('/subscribers'); | ||
|
|
||
| cy.waitLoadFeatureFlags(); | ||
| cy.getByTestId('side-nav-subscribers-link').click(); |
There was a problem hiding this comment.
when using the cy.visit('/subscribers'); it looks like that application is hanging with the loader... @antonjoel82 we have to verify that when the token is expired and the user refreshes the page he will be navigated to the login page...
There was a problem hiding this comment.
Validated this manually, but as mentioned via slack and the original PR, we deemed it wasn't worthwhile to try to fix and fight with all these tests if we're going to delete them this week anyway.
I elected to skip in this PR (#5570)
| cy.waitLoadFeatureFlags(() => { | ||
| cy.visit('/auth/login'); | ||
| }); |
There was a problem hiding this comment.
wait for LD mocked request to finish
There was a problem hiding this comment.
I don't think this is necessary because we don't block at /auth/login anyway
There was a problem hiding this comment.
all the routes are wrapped in LD provider... but I'll check it, because I've added all the changes at the same time which helped
LetItRock
force-pushed
the
fix-failing-e2e-after-launch-darkly-changes
branch
from
3137692
to
4c9a6f5
Compare
LetItRock
force-pushed
the
fix-failing-e2e-after-launch-darkly-changes
branch
5 times, most recently
from
1a77a21
to
67f8a83
Compare
… with the async launch darkly
LetItRock
force-pushed
the
fix-failing-e2e-after-launch-darkly-changes
branch
from
67f8a83
to
9e060b9
Compare
… with the async launch darkly (#5575)
What changed? Why was the change needed?
Fixed a couple of failing e2e tests in the Web application.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer