fix scrolling not working in term previewers for windows #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jamestrew |
jamestrew
requested changes
Dec 16, 2023
| @@ -225,7 +225,8 @@ previewers.new_termopen_previewer = function(opts) | |||
| return | |||
| end | |||
|
|
|||
| vim.fn.chansend(term_id, termcode) | |||
| vim.fn.chansend(term_id, termcode .. (utils.is_windows() and "\r\n" or "")) | |||
| vim.api.nvim_buf_call(self.state.termopen_bufnr, function() vim.cmd("normal! G") end) | |||
There was a problem hiding this comment.
you found that this was necessary on windows? just confirming.
There was a problem hiding this comment.
yes, working like a charm in Windows 11
| @@ -225,7 +225,8 @@ previewers.new_termopen_previewer = function(opts) | |||
| return | |||
| end | |||
|
|
|||
| vim.fn.chansend(term_id, termcode) | |||
| vim.fn.chansend(term_id, termcode .. (utils.is_windows() and "\r\n" or "")) | |||
There was a problem hiding this comment.
can you try this? the docs say when passing a list, we can include an final empty string to send a final newline. That might simplify things and remove the need to check for is_windows.
Suggested change
| vim.fn.chansend(term_id, termcode .. (utils.is_windows() and "\r\n" or "")) | |
| vim.fn.chansend(term_id, { termcode, "" }) |
There was a problem hiding this comment.
If we do this, we will also affect unix-like systems with change, have you tested it preserves the same behavior on unix-like systems ? I will do the windows test next week
There was a problem hiding this comment.
Yeah my suggestion works on Linux. Just curious if it will on windows as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2764
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
refer to the issue that this PR fixes for details ( #2764 )
Checklist: