chore: add type annotations #2856
Draft
+159
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip-checks: true
jamestrew
commented
Jan 10, 2024
| --- Picker is the main UI that shows up to interact w/ your results. | ||
| -- Takes a filter & a previewer | ||
| ---@class TelescopeBasePicker |
There was a problem hiding this comment.
this feels pretty ridiculous lol
jamestrew
commented
Jan 10, 2024
| Parameters: ~ | ||
| {opts} (table) options to pass to the picker | ||
| TelescopeLiveGrepOpts *TelescopeLiveGrepOpts* | ||
| TelescopeBasePickerOpts |
|
@Conni2461 what do you think? |
|
i guess we can do that. i havent made up my mind regarding lua language servers annotations. they aren't compatible with emmylua annotations which are used within docgen (its uses a lua treesitter parser with emmylua support). fyi there is also this: #1954 |
Yeah I actually made an issue on tree-sitter-lua about (me) potentially adding or converting the ts grammar to support luals annotations. I know this is something neovim core eventually would like for their docgen purposes as well. Somebody just needs to do it. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying something out.
I like types and I think it can help with our documentation deficiencies as well (eg. confusions around why you can pass
default_texttofind_filesand why it's not documented, where to document it, etc, but this might need some enhancements to tree-sitter-lua since the newer luals luacats annotation support is limited).